Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camera sensors db addition Nikon D500 #625

Closed
jsa2340 opened this issue Apr 23, 2019 · 8 comments
Closed

camera sensors db addition Nikon D500 #625

jsa2340 opened this issue Apr 23, 2019 · 8 comments

Comments

@jsa2340
Copy link

jsa2340 commented Apr 23, 2019

Add,
Nikon;D500;23.5;

The existing Nikon;Nikon D500;23.5 generates a warning.

I am using RAW image files for what it's worth.

@a4guy
Copy link

a4guy commented May 7, 2019

ok

@natowi
Copy link
Member

natowi commented Jun 5, 2019

Will be fixed with the next release.

@jsa2340
Copy link
Author

jsa2340 commented Jun 5, 2019

Thanks

@natowi
Copy link
Member

natowi commented Jun 5, 2019

I just checked this with a few images. Meshroom (based on alicevision) can already handle brand and model variations:

[warning] image: 'DSC_226.jpg'
- image camera brand: NIKON CORPORATION
- image camera model: NIKON D500

    - database camera brand: Nikon
    - database camera model: Nikon D500
    - database camera sensor size: 23.5 mm

or

[warning] image: 'DSC_1825.NEF'
- image camera brand: Nikon
- image camera model: D500

    - database camera brand: Nikon
    - database camera model: Nikon D500
    - database camera sensor size: 23.5 mm

@jsa2340
Copy link
Author

jsa2340 commented Jun 6, 2019

I needed to remove Nikon from the camera model for the warning to cease.
`

  • database camera brand: Nikon
  • database camera model: D500
  • database camera sensor size: 23.5 mm`

@natowi
Copy link
Member

natowi commented Jun 6, 2019

This is just the notification that Meshroom/alicevision did not find an exact match in the database and is using the closest match (Nikon;Nikon D500;23.5). If you are using Meshroom GUI, you can ignore this message - or are you using the Alicevision CLI and can not continue unless you modify the database?

Changing Nikon;Nikon D500;23.5; to Nikon;D500;23.5; by default would solve the warning message for you, but would now appear for users with the model metadata Nikon D500...


[10:35:47.580347][warning] The camera found in the database is slightly different for image(s):
[10:35:47.581340][warning] image: 'DSC_1825.NEF'
- image camera brand: Nikon
- image camera model: D500
- database camera brand: Nikon
- database camera model: Nikon D500
- database camera sensor size: 23.5 mm
[10:35:47.583324][warning] Please check and correct camera model(s) name in the database.

@fabiencastan we might want to clarify the warning messages in this case, to inform the user that it is not necessary to correct the camera model in the database, if the correct variation is detected.

@jsa2340
Copy link
Author

jsa2340 commented Jun 6, 2019

Meshroom GUI. I could continue, though uncertain of how it might impact results.

I just added Nikon;D500;23.5 leaving the verbose Nikon D500 version in place. It caused no issue for me, having both in place, so I suspect the reverse would be true.

@fabiencastan
Copy link
Member

This will not impact the result as far as the mapping is correct.
The goal of the warning is to allow users to check the mapping. In you case the mapping between "Nikon/D500" and "Nikon/Nikon D500" is obviously fine.

As there is no good way to deal with this mapping, we prefer to keep a warning to ensure that we don't get a border case mapping together 2 completely different cameras.

@natowi natowi closed this as completed Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants