From 37fe00bf45101e0b02df2435ad7dc0057e9788b2 Mon Sep 17 00:00:00 2001 From: Rayron Victor Date: Tue, 24 Apr 2018 14:56:37 -0300 Subject: [PATCH] Using SDK Version variables from root project Instead of assuming the `compileSdkVersion`, `targetSdkVersion`, etc, read it from the root project. Default `compileSdkVersion` and `targetSdkVersion` to the latest versions. Android Target API Level 26 will be required in August 2018. https://android-developers.googleblog.com/2017/12/improving-app-security-and-performance.html And the React Native team is already working on this: facebook/react-native#17741 facebook/react-native#18095 --- android/build.gradle | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index 1a99752..a41c6e7 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -9,18 +9,26 @@ buildscript { apply plugin: 'com.android.library' +def _ext = rootProject.ext + +def _reactNativeVersion = _ext.has('reactNative') ? _ext.reactNative : '+' +def _compileSdkVersion = _ext.has('compileSdkVersion') ? _ext.compileSdkVersion : 27 +def _buildToolsVersion = _ext.has('buildToolsVersion') ? _ext.buildToolsVersion : '27.0.3' +def _minSdkVersion = _ext.has('minSdkVersion') ? _ext.minSdkVersion : 16 +def _targetSdkVersion = _ext.has('targetSdkVersion') ? _ext.targetSdkVersion : 27 + android { - compileSdkVersion 23 - buildToolsVersion "23.0.1" + compileSdkVersion _compileSdkVersion + buildToolsVersion _buildToolsVersion defaultConfig { - minSdkVersion 16 - targetSdkVersion 22 + minSdkVersion _minSdkVersion + targetSdkVersion _targetSdkVersion versionCode 1 versionName "1.0" - lintOptions { - abortOnError false - } + } + lintOptions { + abortOnError false } } @@ -29,8 +37,9 @@ repositories { } dependencies { - compile 'com.facebook.react:react-native:+' + //noinspection GradleDynamicVersion + compile "com.facebook.react:react-native:${_reactNativeVersion}" compile group: 'com.github.bumptech.glide', name: 'glide', version: '3.8.0' compile group: 'com.github.bumptech.glide', name: 'okhttp3-integration', version: '1.5.0' - compile 'com.android.support:support-v4:19.1.0' + compile "com.android.support:support-v4:${_compileSdkVersion}.+" }