Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: based on grpc, a service can only have one ephemeral instance. #9261

Closed
caqhy opened this issue Oct 6, 2022 · 5 comments
Closed

BUG: based on grpc, a service can only have one ephemeral instance. #9261

caqhy opened this issue Oct 6, 2022 · 5 comments
Labels
status/duplicate This issue or pull request already exists

Comments

@caqhy
Copy link

caqhy commented Oct 6, 2022

Describe the bug
Based on http, a service can have multiple ephemeral instances.
Based on grpc, a service can only have one ephemeral instance. When different ephemeral instances are registered multiple times in a service, these ephemeral instances will be overwritten. Is this a bug?

Expected behavior
When registering based on grpc, a service can have multiple ephemeral instances.

Actually behavior
When registering based on grpc, the ephemeral instance disappears.

How to Reproduce
Steps to reproduce the behavior:

  1. Use nacos-client version 2.x
  2. Register multiple ephemeral instances using the client

Desktop (please complete the following information):

  • OS: [Windows]
  • Version [nacos-server latest master, nacos-client 2.x]
  • Module [naming]
  • SDK [original]
@caqhy caqhy changed the title Based on grpc, a service can only have one ephemeral instance. BUG: based on grpc, a service can only have one ephemeral instance. Oct 6, 2022
@chenhao26-nineteen
Copy link
Collaborator

Due to certain changes in the registration mechanism of Nacos 2.0, the same client can only register one temporary instance for the same service. However, the batch registration feature of temporary instances is supported in 2.1.1. Please use com.alibaba.nacos.client.naming NacosNamingService # batchRegisterInstance Registers Multiple Instances

@caqhy
Copy link
Author

caqhy commented Oct 6, 2022

@chenhao26-nineteen
Since NacosNamingService # batchRegisterInstance allows the same client to register multiple ephemeral instances, how about letting NacosNamingService # registerInstance also allow the same client to register multiple ephemeral instances?

@chenhao26-nineteen
Copy link
Collaborator

refer #5863

@caqhy
Copy link
Author

caqhy commented Oct 7, 2022

refer #5863

OK, I've seen discussions about issue #5863. But I found out that NacosNamingService#registerInstance allows the same client to register multiple persistent instances, is this correct?

@chenhao26-nineteen
Copy link
Collaborator

yes

@chenhao26-nineteen chenhao26-nineteen added the status/duplicate This issue or pull request already exists label Oct 7, 2022
@KomachiSion KomachiSion closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants