fix(core): fix add effects memo leak in form umount (#2050)

alibaba · Aug 26, 2021 · f753ba1 · f753ba1
1 parent 0cc9067
commit f753ba1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/packages/core/src/__tests__/heart.spec.ts b/packages/core/src/__tests__/heart.spec.ts
@@ -40,3 +40,15 @@ test('add/remove lifecycle', () => {
   heart.publish('event')
   expect(handler).toBeCalledTimes(1)
 })
+
+test('add/clear lifecycle', () => {
+  const handler = jest.fn()
+  const heart = new Heart()
+  heart.addLifeCycles('xxx', [new LifeCycle('event', handler)])
+  heart.addLifeCycles('yyy')
+  heart.publish('event')
+  expect(handler).toBeCalledTimes(1)
+  heart.clear()
+  heart.publish('event')
+  expect(handler).toBeCalledTimes(1)
+})
diff --git a/packages/core/src/models/Heart.ts b/packages/core/src/models/Heart.ts
@@ -68,6 +68,7 @@ export class Heart<Payload = any, Context = any> extends Subscribable {
 
   clear = () => {
     this.lifecycles = []
+    this.outerLifecycles.clear()
     this.unsubscribe()
   }
 }