fix: mutator insert (#977)

alibaba · Jul 27, 2020 · f335632 · f335632
1 parent 71025e6
commit f335632
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/docs/zh-cn/jsx-develop/self-inc-component.md b/docs/zh-cn/jsx-develop/self-inc-component.md
@@ -17,6 +17,7 @@ const App = () => {
           return (
             <div>
               {state.value.map((item, index) => {
+                const onInsertAfter = index => mutators.insert(index + 1, {})
                 const onRemove = index => mutators.remove(index)
                 const onMoveUp = index => mutators.moveUp(index)
                 const onMoveDown = index => mutators.moveDown(index)
@@ -32,6 +33,9 @@ const App = () => {
                       component={Input}
                       title="年龄"
                     />
+                    <Button onClick={onInsertAfter.bind(null, index)}>
+                      insertAfter
+                    </Button>
                     <Button onClick={onRemove.bind(null, index)}>remove</Button>
                     <Button onClick={onMoveUp.bind(null, index)}>up</Button>
                     <Button onClick={onMoveDown.bind(null, index)}>down</Button>
@@ -87,6 +91,7 @@ const App = () => {
           return (
             <div>
               {state.value.map((item, index) => {
+                const onInsertAfter = index => mutators.insert(index + 1, {})
                 const onRemove = index => mutators.remove(index)
                 const onMoveUp = index => mutators.moveUp(index)
                 const onMoveDown = index => mutators.moveDown(index)
@@ -102,6 +107,9 @@ const App = () => {
                       component={Input}
                       title="年龄"
                     />
+                    <Button onClick={onInsertAfter.bind(null, index)}>
+                      insertAfter
+                    </Button>
                     <Button onClick={onRemove.bind(null, index)}>remove</Button>
                     <Button onClick={onMoveUp.bind(null, index)}>up</Button>
                     <Button onClick={onMoveDown.bind(null, index)}>down</Button>

diff --git a/docs/zh-cn/schema-develop/complext-self-inc-component.md b/docs/zh-cn/schema-develop/complext-self-inc-component.md
@@ -138,9 +138,15 @@ const App = () => {
                 selector={[['onFieldValueChange', `userList.${idx}.username`]]}
               >
                 {({ state }) => {
-                  return (state.value === 'morally' ? null : <Button onClick={() => {
-                    mutators.remove(idx)
-                  }}>remove</Button> )
+                  return state.value === 'morally' ? null : (
+                    <Button
+                      onClick={() => {
+                        mutators.remove(idx)
+                      }}
+                    >
+                      remove
+                    </Button>
+                  )
                 }}
               </FormSpy>
             )
@@ -232,6 +238,7 @@ import { SchemaForm, SchemaField, toArr, FormPath } from '@formily/antd'
 const ArrayCustom = props => {
   const { value, schema, className, editable, path, mutators } = props
   const componentProps = schema.getExtendsComponentProps() || {}
+
   const onAdd = () => mutators.push(schema.items.getEmptyValue())
   const onRemove = index => mutators.remove(index)
   const onMoveUp = index => mutators.moveUp(index)

diff --git a/packages/core/src/externals.ts b/packages/core/src/externals.ts
@@ -1024,6 +1024,11 @@ export const createFormExternals = (
           setValue(arr)
           return arr
         }
+        if (origin.length === index) {
+          const arr = origin.concat([value])
+          setValue(arr)
+          return arr
+        }
         const arr = origin.reduce((buf, item, idx) => {
           return idx === index ? buf.concat([value, item]) : buf.concat(item)
         }, [])