Skip to content

Commit

Permalink
refactor: improve test case (#375)
Browse files Browse the repository at this point in the history
* test(@uform/react-schema-renderer): fix test case uncompat bugs

* test(@uform/react-schema-renderer): improve test case

* refactor(@uform/react-schema-renderer): improve test case

* refactor(@uform/react-schema-renderer): improve test case

* refactor(@uform/react-schema-renderer): improve test case
  • Loading branch information
janryWang authored Nov 6, 2019
1 parent 9cd7272 commit dfec008
Show file tree
Hide file tree
Showing 21 changed files with 201 additions and 2,042 deletions.
5 changes: 4 additions & 1 deletion packages/core/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ import {
export * from './shared/lifecycle'
export * from './types'

export function createForm<FieldProps, VirtualFieldProps, FormProps>(
export function createForm<FieldProps, VirtualFieldProps>(
options: IFormCreatorOptions = {}
): IForm {
function onGraphChange({ type, payload }) {
Expand Down Expand Up @@ -120,6 +120,9 @@ export function createForm<FieldProps, VirtualFieldProps, FormProps>(
})
})
if (valuesChanged) {
if (isFn(options.onChange)) {
options.onChange(published.values)
}
heart.publish(LifeCycleTypes.ON_FORM_VALUES_CHANGE, state)
}
if (initialValuesChanged) {
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ export interface IFormCreatorOptions extends IFormStateProps {
useDirty?: boolean
validateFirst?: boolean
editable?: boolean
onChange?: (values: IFormState['values']) => void
onSubmit?: (values: IFormState['values']) => any | Promise<any>
onReset?: () => void
onValidateFailed?: (validated: IFormValidateResult) => void
Expand Down
85 changes: 0 additions & 85 deletions packages/react-schema-renderer/src/__old_tests__/actions.spec.js

This file was deleted.

53 changes: 0 additions & 53 deletions packages/react-schema-renderer/src/__old_tests__/context.spec.js

This file was deleted.

63 changes: 0 additions & 63 deletions packages/react-schema-renderer/src/__old_tests__/destruct.spec.js

This file was deleted.

132 changes: 0 additions & 132 deletions packages/react-schema-renderer/src/__old_tests__/display.spec.js

This file was deleted.

Loading

0 comments on commit dfec008

Please sign in to comment.