From 5374d8f9b92eb855824cc2c7b11372140238c895 Mon Sep 17 00:00:00 2001 From: Alex Styl Date: Thu, 9 Mar 2017 22:24:19 +0000 Subject: [PATCH 1/2] Remove increment in for loop --- .../java/com/alexstyl/specialdates/contact/DeviceContact.java | 2 +- .../alexstyl/specialdates/datedetails/DateDetailsAdapter.java | 2 +- .../alexstyl/specialdates/datedetails/DateDetailsFragment.java | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/mobile/src/main/java/com/alexstyl/specialdates/contact/DeviceContact.java b/mobile/src/main/java/com/alexstyl/specialdates/contact/DeviceContact.java index b6b71bff..108a62a1 100644 --- a/mobile/src/main/java/com/alexstyl/specialdates/contact/DeviceContact.java +++ b/mobile/src/main/java/com/alexstyl/specialdates/contact/DeviceContact.java @@ -58,7 +58,7 @@ public void displayQuickInfo(Context context) { @Override protected List onBuildActions(Context context) { - final ContentResolver resolver = context.getContentResolver(); + ContentResolver resolver = context.getContentResolver(); boolean hasPhoneNumber = ContactUtils.hasPhoneNumber(resolver, getContactID()); List actions = new ArrayList<>(2); if (hasPhoneNumber) { diff --git a/mobile/src/main/java/com/alexstyl/specialdates/datedetails/DateDetailsAdapter.java b/mobile/src/main/java/com/alexstyl/specialdates/datedetails/DateDetailsAdapter.java index 15e62f00..9bdbb4ac 100644 --- a/mobile/src/main/java/com/alexstyl/specialdates/datedetails/DateDetailsAdapter.java +++ b/mobile/src/main/java/com/alexstyl/specialdates/datedetails/DateDetailsAdapter.java @@ -260,7 +260,7 @@ public void onViewDetachedFromWindow(RecyclerView.ViewHolder holder) { dayHolder.clearActions(); } - public ContactEvent getEvent(int position) { + private ContactEvent getEvent(int position) { int eventPosition = getEventPositionFrom(position); return events.get(eventPosition); } diff --git a/mobile/src/main/java/com/alexstyl/specialdates/datedetails/DateDetailsFragment.java b/mobile/src/main/java/com/alexstyl/specialdates/datedetails/DateDetailsFragment.java index 9bf06af0..21ed2b7c 100644 --- a/mobile/src/main/java/com/alexstyl/specialdates/datedetails/DateDetailsFragment.java +++ b/mobile/src/main/java/com/alexstyl/specialdates/datedetails/DateDetailsFragment.java @@ -112,7 +112,6 @@ public void onContactActionsMenuClicked(View view, Contact contact) { for (int i = 0; i < size; i++) { LabeledAction action = actions.get(i); popup.getMenu().add(contact.hashCode(), i, 0, getString(action.getName())); - i++; } popup.setOnMenuItemClickListener(new PopupMenu.OnMenuItemClickListener() { From 781b3267fce4d7e15d1d7d03fe3c4c4eff039717 Mon Sep 17 00:00:00 2001 From: Alex Styl Date: Thu, 9 Mar 2017 22:26:26 +0000 Subject: [PATCH 2/2] Version 7.2 (68) --- build.gradle | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build.gradle b/build.gradle index 095a4758..d813b89d 100644 --- a/build.gradle +++ b/build.gradle @@ -28,6 +28,6 @@ task clean(type: Delete) { ext { androidCompileSdkVersion = 24 androidBuildToolsVersion = '24.0.2' - androidVersionCode = 67 - androidVersionName = '7.1' + androidVersionCode = 68 + androidVersionName = '7.2' }