Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global mappings wrapper/guards #26

Closed
amerlyq opened this issue Nov 29, 2015 · 3 comments
Closed

Global mappings wrapper/guards #26

amerlyq opened this issue Nov 29, 2015 · 3 comments

Comments

@amerlyq
Copy link
Collaborator

amerlyq commented Nov 29, 2015

See enhancement inside 81be809.
Added <Plug> and guards for user mappings.

Planned: extend shortcuts list after #25.

@amerlyq
Copy link
Collaborator Author

amerlyq commented Nov 30, 2015

Added outline for other Ag*, LAg* mappings in ebf90d1.
They became activated automatically, when corresponding <Plug> mappings will be added.

@albfan
Copy link
Owner

albfan commented Dec 11, 2015

What is left to do on this task?, go ahead and finish it.

If something is blocking it, open an issue and isolate it (labeling "blocked by" and "blocking")

Divide and conquer

@amerlyq
Copy link
Collaborator Author

amerlyq commented Dec 11, 2015

Alright, it was blocked, but it's due to fluffy workflow in beginning.
Now as concepts slightly changed, I postulate this work as done and all next upgrades will be separated. By the way, original purpose to keep this branch open was next:

  • make draft for mappings to use
  • wait until feature_args_derive merged
  • fix draft by actual implementation -- (root of all evil)
  • merge this and only than close

This way workflow could be completely parallel.
I still think that separate issue like "Fix primary assumed key mappings" is overkill.
But neither is good my previously described way -- at least for this project. Ideas?

@amerlyq amerlyq closed this as completed Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants