Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate resource name when deploying multiple workspaces #1889

Closed
5 tasks done
craddm opened this issue May 14, 2024 · 0 comments · Fixed by #1885
Closed
5 tasks done

Duplicate resource name when deploying multiple workspaces #1889

craddm opened this issue May 14, 2024 · 0 comments · Fixed by #1885
Assignees
Labels
bug Problem when deploying a Data Safe Haven.

Comments

@craddm
Copy link
Contributor

craddm commented May 14, 2024

✅ Checklist

  • I have searched open and closed issues for duplicates.
  • This is a problem observed when deploying a Data Safe Haven.
  • I can reproduce this with the latest version.
  • I have read through the documentation.
  • This isn't an open-ended question (open a discussion if it is).

💻 System information

  • Operating System: Mac OS Sonoma
  • Data Safe Haven version: develop

🚫 Describe the problem

When deploying an SRE with multiple workspaces, there is an error when uploading the test files.

🌳 Log messages

2024-05-14 13:47:25 [   ERROR]  +  pulumi-python:dynamic:Resource sre_workspaces_file_run_all_tests_bats creating (0s)                               cli.py:98
2024-05-14 13:47:25 [   ERROR]  +  pulumi-python:dynamic:Resource sre_workspaces_file_test_databases_R_R creating (0s)                               cli.py:98
2024-05-14 13:47:25 [   ERROR]  +  pulumi-python:dynamic:Resource sre_workspaces_file_test_databases_sh creating (0s)                                cli.py:98
2024-05-14 13:47:25 [   ERROR]  +  pulumi-python:dynamic:Resource sre_workspaces_file_test_mounted_drives_sh creating (0s)                           cli.py:98
2024-05-14 13:47:25 [   ERROR]  +  pulumi-python:dynamic:Resource sre_workspaces_file_test_databases_python_py creating (0s)                         cli.py:98
2024-05-14 13:47:25 [   ERROR]  +  pulumi-python:dynamic:Resource sre_workspaces_file_test_repository_R_sh creating (0s)                             cli.py:98
2024-05-14 13:47:25 [   ERROR]  +  pulumi-python:dynamic:Resource sre_workspaces_file_run_all_tests_bats creating (0s) error:                cli.py:98
Duplicate resource URN                                                                                                                                                              
'urn:pulumi:shm-lincolnshire-sre-morcilla::data-safe-haven::dsh:sre:WorkspacesComponent$pulumi-python:dynamic:Resource::sre_workspaces_file_run_all_tests_bats'; try giving it a          
unique name                                                                                                                                                                            
2024-05-14 13:47:25 [   ERROR]  +  pulumi-python:dynamic:Resource sre_workspaces_file_test_functionality_R_R creating (0s)                           cli.py:98
2024-05-14 13:47:25 [   ERROR] @                                                                                                                                         cli.py:98
updating................         
3m...............         
8;5;3m....                                                                                                                                            
2024-05-14 13:47:25 [   ERROR]  +  pulumi-python:dynamic:Resource sre_workspaces_file_run_all_tests_bats **creating failed (32s)** error:          cli.py:98
Duplicate resource URN                                                                                                                                                              
'urn:pulumi:shm-lincolnshire-sre-morcilla::data-safe-haven::dsh:sre:WorkspacesComponent$pulumi-python:dynamic:Resource::sre_workspaces_file_run_all_tests_bats'; try giving it a          
unique name                                                                                                                      

Appears to be due a duplicate resource name - the test files are prefixed with sre_workspaces_file_, which is fine when there is just one workspace, but Pulumi wants unique filenames for each workspace.

Note: I have a fix in #1885

♻️ To reproduce

Deploy an SRE with than one workspace.

@craddm craddm added the bug Problem when deploying a Data Safe Haven. label May 14, 2024
@craddm craddm self-assigned this May 14, 2024
@jemrobinson jemrobinson added this to the Release 5.0.0rc2 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Problem when deploying a Data Safe Haven.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants