Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TypedActor from 1.5 branch #6328

Closed
ismaelhamed opened this issue Jan 5, 2023 · 9 comments · Fixed by #6437
Closed

Remove TypedActor from 1.5 branch #6328

ismaelhamed opened this issue Jan 5, 2023 · 9 comments · Fixed by #6437

Comments

@ismaelhamed
Copy link
Member

Just a reminder. Even though the type is already marked obsolete, the removal is still pending.

@Aaronontheweb
Copy link
Member

Yep, good idea.

@F0b0s
Copy link
Contributor

F0b0s commented Jan 8, 2023

Can you explain what branch i need to create PR to? dev?
Also there is a
public interface IHandle<in TMessage>
in the same file and it's not used, can i delete it too?

@ismaelhamed
Copy link
Member Author

@F0b0s Yes, dev is the ongoing development branch for v1.5

IMO, anything related to the TypedActor (including examples and specs, if any) should go away. @Aaronontheweb @Arkatufus is really anyone out there using this implementation of typed actors?

@F0b0s
Copy link
Contributor

F0b0s commented Jan 9, 2023

@ismaelhamed

IMO, anything related to the TypedActor (including examples and specs, if any) should go away

are you sure about deleting examples? We have an example SymbolLookup it written at .NET Framework 4.5 and it's StockActor inherits from TypedActor. Maybe it would be better to rewrite example for .NET Core?

@Aaronontheweb
Copy link
Member

@F0b0s Yes, dev is the ongoing development branch for v1.5

IMO, anything related to the TypedActor (including examples and specs, if any) should go away. @Aaronontheweb @Arkatufus is really anyone out there using this implementation of typed actors?

No, they're all using Untyped and Receive actors

@ismaelhamed
Copy link
Member Author

are you sure about deleting examples? We have an example SymbolLookup it written at .NET Framework 4.5 and it's StockActor inherits from TypedActor. Maybe it would be better to rewrite example for .NET Core?

@F0b0s, @Aaronontheweb has the final word

@Aaronontheweb
Copy link
Member

@F0b0s those samples aren't referenced any more from the main solution IIRC - they can be deleted or modernized onto .NET 6. I'm cool with either - would you like to work on this issue?

@F0b0s
Copy link
Contributor

F0b0s commented Jan 16, 2023

@Aaronontheweb now i'm looking at Akka.Persistence.Sqlite: add Akka.Persistence.Query support

@Aaronontheweb
Copy link
Member

@F0b0s excellent - that would be a great one to take on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants