diff --git a/src/contrib/cluster/Akka.Cluster.Tools/PublishSubscribe/DistributedPubSubSettings.cs b/src/contrib/cluster/Akka.Cluster.Tools/PublishSubscribe/DistributedPubSubSettings.cs index 69055e7d8d8..151d7d6017c 100644 --- a/src/contrib/cluster/Akka.Cluster.Tools/PublishSubscribe/DistributedPubSubSettings.cs +++ b/src/contrib/cluster/Akka.Cluster.Tools/PublishSubscribe/DistributedPubSubSettings.cs @@ -109,23 +109,6 @@ public static DistributedPubSubSettings Create(Config config) /// public bool SendToDeadLettersWhenNoSubscribers { get; } - /// - /// Creates a new instance of the . - /// - /// The role that will host instances. - /// Optional. The routing logic used for distributing messages for topic groups. - /// The gossip interval for propagating topic/subscriber data to other mediators. - /// The amount of time it takes to prune a deactivated subscriber from the network. - /// The maximum number of delta elements that can be propagated in a single gossip tick. - /// Thrown if a user tries to use a with routingLogic. - [Obsolete("Obsolete - please us the full constructor instead. This constructor only exists for backwards API compatibility.")] - public DistributedPubSubSettings( - string role, - RoutingLogic routingLogic, - TimeSpan gossipInterval, - TimeSpan removedTimeToLive, - int maxDeltaElements) : this(role, routingLogic, gossipInterval, removedTimeToLive, maxDeltaElements, true){ } - /// /// Creates a new instance of the . /// diff --git a/src/contrib/cluster/Akka.Cluster.Tools/Singleton/ClusterSingletonProxySettings.cs b/src/contrib/cluster/Akka.Cluster.Tools/Singleton/ClusterSingletonProxySettings.cs index 34892a3ed1f..279e670263c 100644 --- a/src/contrib/cluster/Akka.Cluster.Tools/Singleton/ClusterSingletonProxySettings.cs +++ b/src/contrib/cluster/Akka.Cluster.Tools/Singleton/ClusterSingletonProxySettings.cs @@ -158,20 +158,6 @@ public ClusterSingletonProxySettings WithRole(string role) return Copy(role: role); } - /// - /// Creates a new setting with the specified . - /// - /// This method is immutable and returns a new instance of the setting. - /// - /// - /// The identification level of the singleton proxy. - /// A new setting with the provided . - [Obsolete("For compatibility reasons only. Use method with TimeSpan parameter instead")] - public ClusterSingletonProxySettings WithSingletonIdentificationInterval(string singletonIdentificationInterval) - { - return this; - } - /// /// Creates a new setting with the specified . /// diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.Core.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.Core.verified.txt index 79081047d16..246186de841 100644 --- a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.Core.verified.txt +++ b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.Core.verified.txt @@ -205,9 +205,6 @@ namespace Akka.Cluster.Tools.PublishSubscribe } public sealed class DistributedPubSubSettings : Akka.Actor.INoSerializationVerificationNeeded { - [System.ObsoleteAttribute("Obsolete - please us the full constructor instead. This constructor only exists f" + - "or backwards API compatibility.")] - public DistributedPubSubSettings(string role, Akka.Routing.RoutingLogic routingLogic, System.TimeSpan gossipInterval, System.TimeSpan removedTimeToLive, int maxDeltaElements) { } public DistributedPubSubSettings(string role, Akka.Routing.RoutingLogic routingLogic, System.TimeSpan gossipInterval, System.TimeSpan removedTimeToLive, int maxDeltaElements, bool sendToDeadLettersWhenNoSubscribers) { } public System.TimeSpan GossipInterval { get; } public int MaxDeltaElements { get; } @@ -397,8 +394,6 @@ namespace Akka.Cluster.Tools.Singleton public static Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings Create(Akka.Configuration.Config config, bool considerAppVersion) { } public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithBufferSize(int bufferSize) { } public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithRole(string role) { } - [System.ObsoleteAttribute("For compatibility reasons only. Use method with TimeSpan parameter instead")] - public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonIdentificationInterval(string singletonIdentificationInterval) { } public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonIdentificationInterval(System.TimeSpan singletonIdentificationInterval) { } public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonName(string singletonName) { } } diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.DotNet.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.DotNet.verified.txt index 86e52dd3576..9527f9cd6be 100644 --- a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.DotNet.verified.txt +++ b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.DotNet.verified.txt @@ -205,9 +205,6 @@ namespace Akka.Cluster.Tools.PublishSubscribe } public sealed class DistributedPubSubSettings : Akka.Actor.INoSerializationVerificationNeeded { - [System.ObsoleteAttribute("Obsolete - please us the full constructor instead. This constructor only exists f" + - "or backwards API compatibility.")] - public DistributedPubSubSettings(string role, Akka.Routing.RoutingLogic routingLogic, System.TimeSpan gossipInterval, System.TimeSpan removedTimeToLive, int maxDeltaElements) { } public DistributedPubSubSettings(string role, Akka.Routing.RoutingLogic routingLogic, System.TimeSpan gossipInterval, System.TimeSpan removedTimeToLive, int maxDeltaElements, bool sendToDeadLettersWhenNoSubscribers) { } public System.TimeSpan GossipInterval { get; } public int MaxDeltaElements { get; } @@ -397,8 +394,6 @@ namespace Akka.Cluster.Tools.Singleton public static Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings Create(Akka.Configuration.Config config, bool considerAppVersion) { } public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithBufferSize(int bufferSize) { } public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithRole(string role) { } - [System.ObsoleteAttribute("For compatibility reasons only. Use method with TimeSpan parameter instead")] - public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonIdentificationInterval(string singletonIdentificationInterval) { } public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonIdentificationInterval(System.TimeSpan singletonIdentificationInterval) { } public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonName(string singletonName) { } } diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.Net.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.Net.verified.txt index 79081047d16..246186de841 100644 --- a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.Net.verified.txt +++ b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.Net.verified.txt @@ -205,9 +205,6 @@ namespace Akka.Cluster.Tools.PublishSubscribe } public sealed class DistributedPubSubSettings : Akka.Actor.INoSerializationVerificationNeeded { - [System.ObsoleteAttribute("Obsolete - please us the full constructor instead. This constructor only exists f" + - "or backwards API compatibility.")] - public DistributedPubSubSettings(string role, Akka.Routing.RoutingLogic routingLogic, System.TimeSpan gossipInterval, System.TimeSpan removedTimeToLive, int maxDeltaElements) { } public DistributedPubSubSettings(string role, Akka.Routing.RoutingLogic routingLogic, System.TimeSpan gossipInterval, System.TimeSpan removedTimeToLive, int maxDeltaElements, bool sendToDeadLettersWhenNoSubscribers) { } public System.TimeSpan GossipInterval { get; } public int MaxDeltaElements { get; } @@ -397,8 +394,6 @@ namespace Akka.Cluster.Tools.Singleton public static Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings Create(Akka.Configuration.Config config, bool considerAppVersion) { } public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithBufferSize(int bufferSize) { } public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithRole(string role) { } - [System.ObsoleteAttribute("For compatibility reasons only. Use method with TimeSpan parameter instead")] - public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonIdentificationInterval(string singletonIdentificationInterval) { } public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonIdentificationInterval(System.TimeSpan singletonIdentificationInterval) { } public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonName(string singletonName) { } }