Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segmentation fault in cld-3.4.3 #35

Closed
coezbek opened this issue Jan 19, 2022 · 2 comments
Closed

Segmentation fault in cld-3.4.3 #35

coezbek opened this issue Jan 19, 2022 · 2 comments
Assignees
@akihikodaki
Labels
enhancement

Comments

@coezbek
Copy link

coezbek commented Jan 19, 2022

I am running on Ubuntu 20.04 with Ruby 2.7.2 / cld3-ruby 3.4.3 on WSL and get an segmentation fault, wenn (by accident) I passed identical values to min and max to the constructor CLD3::NNetLanguageIdentifier.new(min, max).

/home/coezbek/.rvm/gems/ruby-2.7.2/gems/cld3-3.4.3/lib/cld3.rb:79: [BUG] Illegal instruction at 0x00007f6501ff37a0
ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-linux]

-- Control frame information -----------------------------------------------
c:0040 p:---- s:0231 e:000230 CFUNC  :new_NNetLanguageIdentifier

libprotobuf.so.17.0.0
@akihikodaki akihikodaki self-assigned this Jan 19, 2022
@akihikodaki
Copy link
Owner

Fixed with commit 585e178.

@akihikodaki
Copy link
Owner

It no longer traps and raises ArgumentError gracefully, but I doubt that it should reject such arguments at first place. I opened google/cld3#65 so let's see if the upstream maintainers agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akihikodaki akihikodaki

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coezbek @akihikodaki