CPM-101: use symfony cache instead of doctrine cache #13665
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doctrine cache bundle is no longer maintained: doctrine/DoctrineCacheBundle#156
Since symfony 4.3 the best way to configure the cache is using the
symfony/cache
component. In this PR the doctrine-cache-bundle is removed and replaced by symfony/cache. The config is migrated to this new component.Which configuration to use?
In our previous configuration we had
The default configuration in SF5 install is defined here: https://github.com/symfony/recipes/blob/master/doctrine/doctrine-bundle/1.6/config/packages/prod/doctrine.yaml
It seems simpler compared to our previous config with a simple and obscure
cache.app
:So I adapt the symfony cache configuration to have the same behavior than before for results only:
The
doctrine.system_cache_pool
is different and used the defaultcache.system
cache. Here is an explaination of this cache https://symfony.com/doc/current/cache.html#configuring-cache-with-frameworkbundleBenchmarks in local
Load and force save 1239 products 5 times in the same process without clearing cache. The results are the same. The cost to fetch/save product from/in the cache is really low compared to the rest.