CPM-101: remove doctrine cache bundle and update doctrine packages versions #13551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a1efea to
0831fb0
Compare
nmarniesse
commented
Dec 18, 2020
| pim: | ||
| chain: | ||
| providers: [doctrine_cache.providers.pim_apcu, doctrine_cache.providers.pim_array] | ||
| column_length: 255 |
There was a problem hiding this comment.
Length for the version column of the migration_versions table. The default for doctrine/migration v2 is 14. That means none of our igration would work....
The length was 255 for the v1
4d2d5a8 to
a78db52
Compare
1d28a02 to
cd987b3
Compare
f7ffe08 to
6edc634
Compare
to remove container-interop/container-interop deprecation
to remove zendframework/zend-diactoros deprecation
to remove container-interop/container-interop deprecation
to remove deprecation on doctrine/reflection and doctrine/doctrine-cache-bundle
…e\Persistence\ManagerRegistry
default is 14 that is not enough
…e\Persistence\ManagerRegistry in tests
6edc634 to
4233bc0
Compare
|
Splitted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doctrine cache bundle
Doctrine cache bundle is no longer maintained: doctrine/DoctrineCacheBundle#156
Since symfony 4.3 the best way to configure the cache is using the
symfony/cachecomponentIn this PR the doctrine-cache-bundle is removed and replaced by symfony/cache. The config is migrated to this new component.
Update doctrine packages versions
One of the initial goal was to remove the
doctrine/reflectionpackage (which is abandoned). But for now thee is some issues to do that: to remove it we need to updatedoctrine/persistencein 2.x anddoctrine/commonin 3.x. But there is some issues with thefriendsofsymfony/rest-bundlethat is the higher version available for now.Major version upgrade:
doctrine/doctrine-migrations-bundleanddoctrine/migrationsare bumped from 1.x to 2.x. The config is adapted. Now themigrate_versiontable has a newexecuted_atcolumn. The column is added automatically no need to do additional work.The BC break about
Doctrine\DBALnamespace is fixed in this PR (see https://github.com/doctrine/migrations/releases/tag/v2.0.0 for further information)