Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide vertical scrollbar when not needed. #1362

Closed
DanielGibbsNZ opened this issue Apr 8, 2013 · 4 comments
Closed

Hide vertical scrollbar when not needed. #1362

DanielGibbsNZ opened this issue Apr 8, 2013 · 4 comments

Comments

@DanielGibbsNZ
Copy link

Currently, the vertical scrollbar is always present, and when there is no need for it (i.e. text does not go past the bottom of the editor) it can look a little messy/out of place (in my opinion). Most text areas only show scrollbars when they are actually needed, and I think this would be a good principle to adopt.

@danyaPostfactum
Copy link
Contributor

+1
@nightwing I think we need to move horizontal scrollbar out of virtual_renderer. We can have scrollbars interface
and implement it using native scrollbars and custom ones (maybe in separate git branch)

Reasons to do it:

  • custom scrollbars feature
  • necessary for native text d'n'd in WebKit ( It scrolls overflow-x div in Y direction while (native) text selection )
  • maybe textarea-like native resizer (for textarea replacement use-cases of ACE)

Will it bring sensible performance issues ?

@nightwing
Copy link
Member

@danyaPostfactum +∞
See #869 for some more reasons to do that.
I rather like scrollbars on http://www.typescriptlang.org/Playground/, (except autohiding), but don't have time to work on that for now.

Will it bring sensible performance issues ?

Getting rid of setting scrollleft will only improve performance since it causes sync reflow

As about hiding vertical scrollbar, there's easier way, (i needed to do it for autocomplete popup)

@bobmonteverde
Copy link

Been trying to figure out where the option is for this, shocking there is no straightforward way. All I want to do is hide the vertical scrollbar until it is needed. This is how the horizontal one works by default, and make a multi editor environment look much sleeker.

I'm tempted to write a hack-ish solution, but i feel this should be a simple built in flag, which most likely should be on by default.

@nightwing
Copy link
Member

added option vScrollBarAlwaysVisible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants