Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The text delimiter of CsvAssetLoader is broken #74

Open
GitHaap opened this issue Jan 6, 2025 · 0 comments
Open

The text delimiter of CsvAssetLoader is broken #74

GitHaap opened this issue Jan 6, 2025 · 0 comments

Comments

@GitHaap
Copy link

GitHaap commented Jan 6, 2025

I always appreciate how convenient your library is.

However, starting from easy_localization_loader v2.0.1, the specification of CsvAssetLoader has changed, and the default behavior has become inconvenient for me.

The Issue

If a single quote is used standalone without enclosing it in double quotes, the text delimiter below that line does not function correctly.

Example

str,en_US,~~~
key1,AAA's BBB,~~~
key2,"CCC, DDD",~~~

I would like it to behave as follows:

key1: AAA's BBB
key2: CCC, DDD

However, when I load this CSV with the default settings of CsvAssetLoader (i.e., AutoDetect = true with no arguments), the result is:

key1: AAA's BBB
key2: "CCC

This seems to happen because the single quote used standalone in key1 breaks the behavior of the text delimiter in key2, causing it to display "CCC.

Suggestion

Wouldn't it be better if the text delimiter only supported double quotes? Is this behavior intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant