Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump testcontainers version to latest #30392

Closed
postamar opened this issue Sep 13, 2023 · 1 comment · Fixed by #30493
Closed

bump testcontainers version to latest #30392

postamar opened this issue Sep 13, 2023 · 1 comment · Fixed by #30493
Assignees
@postamar
Labels
team/db-dw-sources Backlog for Database and Data Warehouse Sources team

Comments

@postamar
Copy link
Contributor

postamar commented Sep 13, 2023 •
edited
Loading

Topic

bump testcontainers version to latest

Revelant information

Bumping testcontainers to the latest version breaks all db-sources integration tests except for source-postgres. This seems to happen only in airbyte-ci. This seems due to a combination of a networking issue, and dagger shutting down the docker-in-docker container too early. Fix this at least for source-mysql.

Related:
#30280
#30032
https://airbytehq-team.slack.com/archives/C043JHEEYKG/p1694015739924069
#30384
@postamar postamar added team/db-dw-sources Backlog for Database and Data Warehouse Sources team and removed needs-triage team/triage labels Sep 13, 2023
@prateekmukhedkar
Copy link
Contributor

Definition of done: CI tests work for source-mysql.

@postamar postamar linked a pull request Sep 20, 2023 that will close this issue
bump testcontainers version to latest #30493
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@postamar postamar

Labels
team/db-dw-sources Backlog for Database and Data Warehouse Sources team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump testcontainers version to latest airbytehq/airbyte
3 participants
@postamar @octavia-squidington-iii @prateekmukhedkar