Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that the actor catalog and configured catalog contains valid jsonschema definitions before persisting #29423

Closed
bnchrch opened this issue Aug 15, 2023 · 0 comments

Comments

@bnchrch
Copy link
Contributor

bnchrch commented Aug 15, 2023

First noticed

https://github.com/airbytehq/oncall/issues/2703

Problem

We do not validate if the catalog emitted from a connector is valid json schema

As a result a catalog was persisted and used for months until the error was eventually caught by the Catalog Diff Method which throws an exception in this case
https://www.jsonschemavalidator.net/s/HU2gflxO

Quick Fix

We loosened the check of the catalog diff: airbytehq/airbyte-protocol#44

Long term fix

Use a JsonSchema validator on every stream definition before writing a catalog or configured catalog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant