From d0273c221bee63ea967c4038c446f2a6164510d8 Mon Sep 17 00:00:00 2001 From: Edward Gao Date: Wed, 5 Jun 2024 14:03:35 -0700 Subject: [PATCH] remove encrypted s3 staging option --- .../RedshiftS3StagingSqlOperations.kt | 3 ++ .../src/main/resources/spec.json | 43 ------------------- 2 files changed, 3 insertions(+), 43 deletions(-) diff --git a/airbyte-integrations/connectors/destination-redshift/src/main/kotlin/io/airbyte/integrations/destination/redshift/operations/RedshiftS3StagingSqlOperations.kt b/airbyte-integrations/connectors/destination-redshift/src/main/kotlin/io/airbyte/integrations/destination/redshift/operations/RedshiftS3StagingSqlOperations.kt index 2b546290d9d6..e1c09ad7c570 100644 --- a/airbyte-integrations/connectors/destination-redshift/src/main/kotlin/io/airbyte/integrations/destination/redshift/operations/RedshiftS3StagingSqlOperations.kt +++ b/airbyte-integrations/connectors/destination-redshift/src/main/kotlin/io/airbyte/integrations/destination/redshift/operations/RedshiftS3StagingSqlOperations.kt @@ -141,6 +141,9 @@ class RedshiftS3StagingSqlOperations( if (keyEncryptingKey == null) { "" } else { + // TODO This is broken (it's using Snowflake SQL syntax). + // Leaving it here since the rest of the plumbing seems reasonable, + // but we should fix this eventually. String.format( " encryption = (type = 'aws_cse' master_key = '%s')", BASE64_ENCODER.encodeToString(keyEncryptingKey) diff --git a/airbyte-integrations/connectors/destination-redshift/src/main/resources/spec.json b/airbyte-integrations/connectors/destination-redshift/src/main/resources/spec.json index 7f291ffc3ba5..c2d9ed97a0d4 100644 --- a/airbyte-integrations/connectors/destination-redshift/src/main/resources/spec.json +++ b/airbyte-integrations/connectors/destination-redshift/src/main/resources/spec.json @@ -180,49 +180,6 @@ "description": "Whether to delete the staging files from S3 after completing the sync. See docs for details.", "default": true, "order": 6 - }, - "encryption": { - "title": "Encryption", - "type": "object", - "description": "How to encrypt the staging data", - "default": { "encryption_type": "none" }, - "oneOf": [ - { - "title": "No encryption", - "description": "Staging data will be stored in plaintext.", - "type": "object", - "required": ["encryption_type"], - "properties": { - "encryption_type": { - "type": "string", - "const": "none", - "enum": ["none"], - "default": "none" - } - } - }, - { - "title": "AES-CBC envelope encryption", - "description": "Staging data will be encrypted using AES-CBC envelope encryption.", - "type": "object", - "required": ["encryption_type"], - "properties": { - "encryption_type": { - "type": "string", - "const": "aes_cbc_envelope", - "enum": ["aes_cbc_envelope"], - "default": "aes_cbc_envelope" - }, - "key_encrypting_key": { - "type": "string", - "title": "Key", - "description": "The key, base64-encoded. Must be either 128, 192, or 256 bits. Leave blank to have Airbyte generate an ephemeral key for each sync.", - "airbyte_secret": true - } - } - } - ], - "order": 7 } } }