From 290b16b0ccdb36d22379b6eff3534c1630fe6c8b Mon Sep 17 00:00:00 2001
From: Joe Reuter <joe@airbyte.io>
Date: Tue, 24 Jan 2023 01:34:09 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=AA=9F=F0=9F=90=9B=20Connector=20builder?=
 =?UTF-8?q?=20UI:=20Fix=20inputs=20modal=20(#21643)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix

* fix

Co-authored-by: Lake Mossman <lake@airbyte.io>
---
 .../components/connectorBuilder/Builder/BuilderField.tsx   | 3 ++-
 .../src/components/connectorBuilder/Builder/InputsForm.tsx | 7 -------
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/airbyte-webapp/src/components/connectorBuilder/Builder/BuilderField.tsx b/airbyte-webapp/src/components/connectorBuilder/Builder/BuilderField.tsx
index 0e2a0f863ac57..497523e3a9b09 100644
--- a/airbyte-webapp/src/components/connectorBuilder/Builder/BuilderField.tsx
+++ b/airbyte-webapp/src/components/connectorBuilder/Builder/BuilderField.tsx
@@ -149,7 +149,8 @@ const InnerBuilderField: React.FC<BuilderFieldProps & FastFieldProps<unknown>> =
 
 export const BuilderField: React.FC<BuilderFieldProps> = (props) => {
   return (
-    <FastField name={props.path}>
+    // The key is set to enforce a re-render of the component if the type change, otherwise changes in props might not be reflected correctly
+    <FastField name={props.path} key={props.type}>
       {({ field, form, meta }: FastFieldProps<unknown>) => (
         <InnerBuilderField {...props} field={field} form={form} meta={meta} />
       )}
diff --git a/airbyte-webapp/src/components/connectorBuilder/Builder/InputsForm.tsx b/airbyte-webapp/src/components/connectorBuilder/Builder/InputsForm.tsx
index 33f0e94a1ca60..2ab7c5415aa77 100644
--- a/airbyte-webapp/src/components/connectorBuilder/Builder/InputsForm.tsx
+++ b/airbyte-webapp/src/components/connectorBuilder/Builder/InputsForm.tsx
@@ -242,13 +242,6 @@ const InputModal = ({
                   label={formatMessage({ id: "connectorBuilder.inputModal.default" })}
                 />
               )}
-              <BuilderField
-                path="definition.placeholder"
-                type="string"
-                optional
-                label={formatMessage({ id: "connectorBuilder.inputModal.placeholder" })}
-                tooltip={formatMessage({ id: "connectorBuilder.inputModal.placeholderTooltip" })}
-              />
             </>
           ) : (
             <Callout className={styles.calloutContainer}>