diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index a1da3af86..1751ca9fe 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -110,7 +110,7 @@ Extremely helpful in meeting the threshold. ## 🎨 Styleguide Requirements Our styleguide (powered by [Storybook](https://storybook.js.org/)) requires a bit of manual -documentation of components to be properly infer prop types. +documenting of components to properly infer prop types. - Component definitions require a [docblock comment description](https://github.com/reactjs/react-docgen#proptypes). Furthermore, a diff --git a/packages/core/src/components/FormActions.story.tsx b/packages/core/src/components/FormActions.story.tsx index c91521deb..091e663b3 100644 --- a/packages/core/src/components/FormActions.story.tsx +++ b/packages/core/src/components/FormActions.story.tsx @@ -20,4 +20,5 @@ storiesOf('Core/FormActions', module) .add('With a reset button.', () => ) .add('With small buttons in a processing state.', () => ( - )); + )) + .add('In a danger state.', () => ); diff --git a/packages/forms/src/components/Autocomplete.story.tsx b/packages/forms/src/components/Autocomplete.story.tsx index 2f5747bcf..fce2b549b 100644 --- a/packages/forms/src/components/Autocomplete.story.tsx +++ b/packages/forms/src/components/Autocomplete.story.tsx @@ -16,7 +16,13 @@ storiesOf('Forms/Autocomplete', module) inspectComponents: [Autocomplete], }) .add('Connected to the parent `Form`.', () => ( -
+ { + action('onSubmit')(); + + return Promise.resolve(); + }} + > ( - + { + action('onSubmit')(); + + return Promise.resolve(); + }} + > {}} /> )); diff --git a/packages/forms/src/components/CheckBoxController.story.tsx b/packages/forms/src/components/CheckBoxController.story.tsx index 5baeac5e6..015f1f8fe 100644 --- a/packages/forms/src/components/CheckBoxController.story.tsx +++ b/packages/forms/src/components/CheckBoxController.story.tsx @@ -9,7 +9,13 @@ storiesOf('Forms/CheckBoxController', module) inspectComponents: [CheckBoxController], }) .add('Connected to the parent `Form`.', () => ( -
+ { + action('onSubmit')(); + + return Promise.resolve(); + }} + > {}}> {CheckBox => (
diff --git a/packages/forms/src/components/DatePickerInput.story.tsx b/packages/forms/src/components/DatePickerInput.story.tsx index c5bd87d45..1b8c19e07 100644 --- a/packages/forms/src/components/DatePickerInput.story.tsx +++ b/packages/forms/src/components/DatePickerInput.story.tsx @@ -9,7 +9,13 @@ storiesOf('Forms/DatePickerInput', module) inspectComponents: [DatePickerInput], }) .add('Connected to the parent `Form`.', () => ( - + { + action('onSubmit')(); + + return Promise.resolve(); + }} + > {}} /> )); diff --git a/packages/forms/src/components/DateTimeSelect.story.tsx b/packages/forms/src/components/DateTimeSelect.story.tsx index fd86ffb04..f5040eea6 100644 --- a/packages/forms/src/components/DateTimeSelect.story.tsx +++ b/packages/forms/src/components/DateTimeSelect.story.tsx @@ -9,7 +9,13 @@ storiesOf('Forms/DateTimeSelect', module) inspectComponents: [DateTimeSelect], }) .add('Connected to the parent `Form`.', () => ( -
+ { + action('onSubmit')(); + + return Promise.resolve(); + }} + > {}} /> )); diff --git a/packages/forms/src/components/FeedbackForm.story.tsx b/packages/forms/src/components/FeedbackForm.story.tsx index 14beef3d9..4e50072a6 100644 --- a/packages/forms/src/components/FeedbackForm.story.tsx +++ b/packages/forms/src/components/FeedbackForm.story.tsx @@ -16,7 +16,11 @@ storiesOf('Forms/FeedbackForm', module) channel="Lunar" channelID={1} teamID={2} - onSubmit={action('onSubmit')} + onSubmit={() => { + action('onSubmit')(); + + return Promise.resolve(); + }} /> )) .add('Without bug reporting.', () => ( @@ -28,7 +32,11 @@ storiesOf('Forms/FeedbackForm', module) channel="Lunar" channelID={1} teamID={2} - onSubmit={action('onSubmit')} + onSubmit={() => { + action('onSubmit')(); + + return Promise.resolve(); + }} disableBugReporting /> )); diff --git a/packages/forms/src/components/FileInput.story.tsx b/packages/forms/src/components/FileInput.story.tsx index 74fc95d7a..a3b2ce9e5 100644 --- a/packages/forms/src/components/FileInput.story.tsx +++ b/packages/forms/src/components/FileInput.story.tsx @@ -9,7 +9,13 @@ storiesOf('Forms/FileInput', module) inspectComponents: [FileInput], }) .add('Connected to the parent `Form`.', () => ( -
+ { + action('onSubmit')(); + + return Promise.resolve(); + }} + > {}} /> )); diff --git a/packages/forms/src/components/FilterMenu.story.tsx b/packages/forms/src/components/FilterMenu.story.tsx index 7c4de3c16..7e8223c33 100644 --- a/packages/forms/src/components/FilterMenu.story.tsx +++ b/packages/forms/src/components/FilterMenu.story.tsx @@ -12,7 +12,13 @@ storiesOf('Forms/FilterMenu', module) }) .addDecorator(story =>
{story()}
) .add('Form in a dropdown.', () => ( -
+ { + action('onSubmit')(); + + return Promise.resolve(); + }} + >
)) .add('Left-aligned menu.', () => ( - + { + action('onSubmit')(); + + return Promise.resolve(); + }} + > ( - + { + action('onSubmit')(); + + return Promise.resolve(); + }} + > )); diff --git a/packages/forms/src/components/Input.story.tsx b/packages/forms/src/components/Input.story.tsx index f539908d0..b1027efb8 100644 --- a/packages/forms/src/components/Input.story.tsx +++ b/packages/forms/src/components/Input.story.tsx @@ -9,7 +9,13 @@ storiesOf('Forms/Input', module) inspectComponents: [Input], }) .add('Connected to the parent `Form`.', () => ( -
+ { + action('onSubmit')(); + + return Promise.resolve(); + }} + > {}} />
)); diff --git a/packages/forms/src/components/Multicomplete.story.tsx b/packages/forms/src/components/Multicomplete.story.tsx index 2c62d5db8..bc91c15eb 100644 --- a/packages/forms/src/components/Multicomplete.story.tsx +++ b/packages/forms/src/components/Multicomplete.story.tsx @@ -16,7 +16,13 @@ storiesOf('Forms/Multicomplete', module) inspectComponents: [Multicomplete], }) .add('Connected to the parent `Form`.', () => ( -
+ { + action('onSubmit')(); + + return Promise.resolve(); + }} + > ( - + { + action('onSubmit')(); + + return Promise.resolve(); + }} + > {}}> {RadioButton => (
diff --git a/packages/forms/src/components/Select.story.tsx b/packages/forms/src/components/Select.story.tsx index 3b5de17cb..81a1bc928 100644 --- a/packages/forms/src/components/Select.story.tsx +++ b/packages/forms/src/components/Select.story.tsx @@ -9,7 +9,13 @@ storiesOf('Forms/Select', module) inspectComponents: [Select], }) .add('Connected to the parent `Form`.', () => ( - + { + action('onSubmit')(); + + return Promise.resolve(); + }} + >