-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RuntimeWarning on Python 3.8 #348
Comments
Thanks for the report! |
Looks like Cython 0.29.12 fixes it. |
The import succeeds and only a RuntimeWarning occurs now with Python 3.8.0b2. |
Solved by #355. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Attempting to import multidict using Python
3.8.0a43.8.0b1 raises a SystemError3.8.0b2 causes a RuntimeWarning to occur.Reproduction Steps
3.8.0a43.8.0b13.8.0b2import multidict
tracebackwarningExpected Behavior
Successful importNo warning
Traceback
Traceback (most recent call last):File "", line 1, inFile "C:\Program Files\Python38\lib\site-packages\multidict_init_.py", line 23, infrom ._multidict import (MultiDictProxy,SystemError: c:_work\14\s\objects\codeobject.c:131: bad argument to internal functionPython Version
Python 3.8.0a4 (v3.8.0a4:c1004b8546, May 7 2019, 13:53:12) [MSC v.1916 64 bit (AMD64)] on win32Python 3.8.0b1 (tags/v3.8.0b1:3b5deb0116, Jun 4 2019, 19:52:55) [MSC v.1916 64 bit (AMD64)] on win32Python 3.8.0b2 (tags/v3.8.0b2:21dd01d, Jul 4 2019, 16:00:09) [MSC v.1916 64 bit (AMD64)] on win32
multidict Version
multidict 4.5.2
Additional Context
This seems to be caused by changes to
PyCode_New
as part of the implementation of PEP 570:python/cpython@8c77b8c#diff-e3862c228cffe90385cf9f14529868fe (python/cpython#12701)
bpo-37221 has reverted
PyCode_New
to be a backwards compatible wrapper for a newPyCode_NewEx
with python/cpython@cb083f7 (python/cpython#13959, python/cpython#14505).The handling for this change was added in Cython 0.29.11 with cython/cython@9b6a02f (cython/cython#3009) and fixed in Cython 0.29.12 with cython/cython@0d88839 (cython/cython#3031, cython/cython#3034).
Updating to Cython 0.29.12 should now resolve this issue.
The text was updated successfully, but these errors were encountered: