Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit initialization and running stages to web.Application #385

Closed
asvetlov opened this issue May 30, 2015 · 3 comments
Closed

Add explicit initialization and running stages to web.Application #385

asvetlov opened this issue May 30, 2015 · 3 comments
Labels

Comments

@asvetlov
Copy link
Member

Now we have read-only tuple property named middlewares for web.Application.

It's inconvenient a bit, see example from aiohttp_debugtoolbar:

import aiohttp_debugtoolbar
app = web.Application(loop=loop,
                       middlewares=[aiohttp_debugtoolbar.middleware])
aiohttp_debugtoolbar.setup(app)

I guess to allow modify app.middlewares on setup stage (make it readwrite list property) but after first app.make_handler() call it should be converted to readonly tuple property.

Perhaps we need app.freeze() and even app.unfreeze() methods as well as app.frozen property.

router API also may be extended to allow for adding new routes only in non-frozen stage.

@fafhrd91
Copy link
Member

-1, it is way too complicated

@fafhrd91
Copy link
Member

just make it list

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants