From 2ef0ac67308c6f2ae0a87ac2cb6ddb2211b5e180 Mon Sep 17 00:00:00 2001 From: Jusong Yu Date: Mon, 8 Aug 2022 14:41:25 +0000 Subject: [PATCH 1/3] Set installed traitlets of pseudo install widget when it's done --- aiidalab_qe/sssp.py | 1 + 1 file changed, 1 insertion(+) diff --git a/aiidalab_qe/sssp.py b/aiidalab_qe/sssp.py index 0f100681f..1f6db9e74 100644 --- a/aiidalab_qe/sssp.py +++ b/aiidalab_qe/sssp.py @@ -102,6 +102,7 @@ def _refresh_installed(self): self.set_trait("error", str(error)) self.set_message(str(error)) else: + self.installed = True self.set_message("OK") finally: self.set_trait("busy", False) From 7b7d40ece82d10e16812b568d3cdd3391bd753dd Mon Sep 17 00:00:00 2001 From: Jusong Yu Date: Mon, 8 Aug 2022 14:43:23 +0000 Subject: [PATCH 2/3] Qeinstall also --- aiidalab_qe/setup_codes.py | 1 + aiidalab_qe/sssp.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/aiidalab_qe/setup_codes.py b/aiidalab_qe/setup_codes.py index e72cd8262..38b3e13c9 100644 --- a/aiidalab_qe/setup_codes.py +++ b/aiidalab_qe/setup_codes.py @@ -219,6 +219,7 @@ def _refresh_installed(self): self.set_trait("error", str(error)) FN_DO_NOT_SETUP.touch() else: + self.set_trait("installed", True) self.set_message("OK") finally: self.set_trait("busy", False) diff --git a/aiidalab_qe/sssp.py b/aiidalab_qe/sssp.py index 1f6db9e74..f9a7136ee 100644 --- a/aiidalab_qe/sssp.py +++ b/aiidalab_qe/sssp.py @@ -102,7 +102,7 @@ def _refresh_installed(self): self.set_trait("error", str(error)) self.set_message(str(error)) else: - self.installed = True + self.set_trait("installed", True) self.set_message("OK") finally: self.set_trait("busy", False) From e3ec04b634b34cc92d8d1651ec130a07e4b70744 Mon Sep 17 00:00:00 2001 From: Jusong Yu Date: Mon, 8 Aug 2022 16:55:32 +0000 Subject: [PATCH 3/3] review --- aiidalab_qe/setup_codes.py | 2 -- aiidalab_qe/sssp.py | 3 ++- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/aiidalab_qe/setup_codes.py b/aiidalab_qe/setup_codes.py index 38b3e13c9..11d726b31 100644 --- a/aiidalab_qe/setup_codes.py +++ b/aiidalab_qe/setup_codes.py @@ -212,8 +212,6 @@ def _refresh_installed(self): for msg in install(): self.set_message(msg) - self.installed = True - except Exception as error: self.set_message("Failed to setup QE on localhost.") self.set_trait("error", str(error)) diff --git a/aiidalab_qe/sssp.py b/aiidalab_qe/sssp.py index f9a7136ee..64727e954 100644 --- a/aiidalab_qe/sssp.py +++ b/aiidalab_qe/sssp.py @@ -102,7 +102,8 @@ def _refresh_installed(self): self.set_trait("error", str(error)) self.set_message(str(error)) else: - self.set_trait("installed", True) + # If all the libraries are install by hands `pseudos_to_install()` will be empty list. + self.set_trait("installed", not bool(pseudos_to_install())) self.set_message("OK") finally: self.set_trait("busy", False)