Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the pdos plot #821

Closed
superstar54 opened this issue Sep 26, 2024 · 0 comments · Fixed by #833
Closed

Improve the pdos plot #821

superstar54 opened this issue Sep 26, 2024 · 0 comments · Fixed by #833
Assignees
Labels
enhancement New feature or request

Comments

@superstar54
Copy link
Member

Ensure band plot is the same when combined with PDOS or when not combined (combined looks better). See also other issue being discussed by C&G. In particular, have horizontal line at Fermi level.

Default PDOS zoom/scaling: for the starting one, scale PDOS max value only in visible range (if you do PDOS of gold, it’s very tiny because, out of scale, there are the semicore p levels). Only use the max pdos from the home.

Screenshot from 2024-09-26 11-47-57

Default zoom: PDOS look tiny. I would do zoom within the visible range.

Screenshot from 2024-09-26 11-48-03

If I do autoscale, I see why - semicore p at ~-60eV.

PDOS selectors:

  • Do not require ‘update plot’ button. If you want it only for the text box ‘select atoms’, move button to the right and call it ‘apply’, only for select atoms.
  • In select atoms, leave in gray an example of the syntax, e.g. “1,2,4-6” or similar
  • Do not sum “1s” and “2s”
  • Change “Update plot” to “apply selection”. And selection from the dropdown should affect immediately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants