diff --git a/web/package/agama-web-ui.changes b/web/package/agama-web-ui.changes index cc3e4423b2..669cfee8e3 100644 --- a/web/package/agama-web-ui.changes +++ b/web/package/agama-web-ui.changes @@ -1,3 +1,9 @@ +------------------------------------------------------------------- +Thu May 23 07:28:44 UTC 2024 - Josef Reidinger + +- Fix showing count in pattern search and also improve visuals + when there are no matching text (gh#openSUSE/agama#1248) + ------------------------------------------------------------------- Wed May 22 14:26:18 UTC 2024 - Josef Reidinger diff --git a/web/src/components/software/PatternSelector.jsx b/web/src/components/software/PatternSelector.jsx index 006587c700..2218fc9dcf 100644 --- a/web/src/components/software/PatternSelector.jsx +++ b/web/src/components/software/PatternSelector.jsx @@ -143,7 +143,7 @@ function PatternSelector({ patterns, onSelectionChanged = noop }) { ); - const selector = sortGroups(groups).map((groupName) => { + let selector = sortGroups(groups).map((groupName) => { const selectedIds = groups[groupName].filter((p) => p.selectedBy !== SelectedBy.NONE).map((p) => p.name ); @@ -166,6 +166,12 @@ function PatternSelector({ patterns, onSelectionChanged = noop }) { ); }); + if (selector.length === 0) { + selector = ( + {_("None of the patterns match the filter.")} + ); + } + return ( <>
@@ -176,8 +182,7 @@ function PatternSelector({ patterns, onSelectionChanged = noop }) { value={searchValue} onChange={(_event, value) => setSearchValue(value)} onClear={() => setSearchValue("")} - // do not display the counter when search filter is empty - resultsCount={searchValue === "" ? 0 : groups.length} + resultsCount={visiblePatterns.length} />