Support for yarn@berry

[rault-a]

Package version

6.9.0

Describe the bug

Hello 👋🏻

When adding a package with node ace add, it throw an error and crashes when using yarn berry (yarn v2, v3 or v4).

In @antfu/install-pkg, when using yarn berry, it returns yarn@berry instead of yarn but @adonisjs/core checks that the package manager is yarn, npm or pnpm. Just adding yarn@berry to the list of supported package managers in commands/add.ts:48 fixes the issue.

Also, @antfu/install-pkg can return pnpm@6 for older version of pnpm, or bun for bun, but I did not test those.

I can do a PR for this issue if you want, at least for yarn@berry, not sure the support for bun or the older versions of pnpm is something that we want.

Reproduction repo

No response

[Julien-R44]

I'm not at all familiar with Yarn Berry. Does Adonis work with Yarn Berry? Have you been able to try?
There are also potentially other places to modify to support yarn berry:

• The Bundler used during the build process:
  • https://github.com/adonisjs/assembler/blob/develop/src/bundler.ts#L29

  • core/commands/build.ts

    Line 41 in a508bb0

    declare packageManager?: 'npm' | 'pnpm' | 'yarn' | 'bun'

• The codemods: https://github.com/adonisjs/core/blob/develop/modules/ace/codemods.ts#L90
• And maybe create-adonisjs but I don't think so? https://github.com/adonisjs/create-adonisjs/blob/c6b8b5ede8387fe6ff2a1539e2089a3a179378eb/commands/main.ts#L92

As I was saying, I think nobody in the team is super familiar with yarn berry. So this is an initiative that someone in the community should lead

About older version of pnpm and bun, I would say no. AdonisJS still doesnt work with Bun, so its kind of pointless. And older versions of pnpm were released before AdonisJS 6.

[thetutlage]

Yeah. I think our goal is to support npm and pnpm (latest) versions. Yarn had massive changes with every version and we are not even aware of what all those changes are. Bun is also very much in experimental state.

Infact, we recently updated our docs to just mention npm commands for the same reason.

I will close this issue for now.

[rault-a]

For the record if needed, I have indeed been able to try by patching locally adonis and it works perfecly once the support for yarn berry is added.
Also, yarn did not have massive change since yarn 2 that came out 4 years ago.
Wouldn't it be a good idea to allow people to use it even with no guarantee of support?

[RomainLanz]

I agree with @rault-a. We should not stop people trying to use Yarn Berry or Bun to install dependencies.

It seems to be an easy fix that will help people that already know what they are doing.

[Julien-R44]

Yeah same. If we are sure that Adonis works correctly with these packages manager and that it only requires a few lines to be changed, then I don't see any reason to not support it

Especially as Yarn has a huge number of users, more than pnpm if I am not wrong. Not supporting it would cut us off from a large part of the community

[rault-a]

Hello, I quickly check the other places mentioned by @Julien-R44 (because I did not had any issue between node ace add with yarn berry and patching the line I mentioned alone allowed me to make it work).

It seems those places (codemod and bundler) fallback on npm when encountering a non supported package manager (ignoring the yarn.lock in case of the bundler), so there is indeed a bit more work to be done than expected, but still minimal.

For the create-adonisjs, I do not think it is a major issue however: yarn berry is installed by project, not globally, so if yarn v1 is supported, it should be enough, the user can easily migrate to yarn berry after the installation (but another improvement could be to automatically use yarn berry in this case during installation).

Still open to make the PR if needed, at least for the node ace add, codemod and bundler, the update of create-adonisjs seems like a more major change.

[Julien-R44]

Yup, happy to accept a PR for that! Thanks

[thetutlage]

Can this we closed since the PR has been merged?

[RomainLanz]

Yes!

[Julien-R44]

We are still missing updates for the bundler, codemods and create-adonisjs

@rault-a do you plan to create a PR for this ?

[rault-a]

Yes, but I am waiting for the release of the assembler, required to update the core (otherwise, there is a typing issue)

[Julien-R44]

Done https://github.com/adonisjs/assembler/releases/tag/v7.6.1