Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Empty tags in embedded SVG break live HTML #5822

Closed
njx opened this issue Nov 2, 2013 · 3 comments
Closed

Empty tags in embedded SVG break live HTML #5822

njx opened this issue Nov 2, 2013 · 3 comments
Assignees
@njx
Labels
fix in progress

Comments

@njx
Copy link

njx commented Nov 2, 2013

  1. In the brackets repo, open src/styles/images/brackets_icon.svg and copy the content
  2. Open the Getting Started project
  3. Paste the Brackets logo SVG into index.html
  4. Start live preview
  5. Type some text

Result: Live preview shows an error in the SVG.
@njx
Copy link
Author

njx commented Nov 2, 2013

The issue is that if we see a self-closing tag that's not a known void element, we don't properly close it when we encounter the "selfclosingtag" notification from the tokenizer--we just treat it the same as "opentagend". Instead, we should pop the element from the tag stack.

@ghost ghost assigned njx Nov 2, 2013
@njx
Copy link
Author

njx commented Nov 2, 2013

Medium priority to me--we don't fully support SVG live editing, but having valid SVG in an ordinary HTML page shouldn't break live development.

@njx njx mentioned this issue Nov 2, 2013
Merged
@njx njx mentioned this issue Nov 10, 2013
Closed
@njx
Copy link
Author

njx commented Nov 11, 2013

Closing as fixed.

@njx njx closed this as completed Nov 11, 2013
@core-ai-bot core-ai-bot mentioned this issue Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@njx njx

Labels
fix in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@njx