Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Spurious no-op edit occurs when ctrl+clicking menu bar #1129

Closed
peterflynn opened this issue Jun 22, 2012 · 5 comments
Closed

Spurious no-op edit occurs when ctrl+clicking menu bar #1129

peterflynn opened this issue Jun 22, 2012 · 5 comments

Comments

@peterflynn
Copy link
Member

This occurs in sprint-9 too, so it predates the context menu work. Very strange bug...

  1. Open a file
  2. Select some text
  3. Ctrl+click a top-level menu in the menu bar (e.g. Navigate)

Result: File is marked dirty, but the text does not appear to have been changed (although your selection is lost). If you undo, the dirty flag goes away, but the text again does not change.

Expected: Nothing should happen (other than the menu opening).

@peterflynn
Copy link
Member Author

Under the hood, CodeMirror is generating an edit that replaces the selection with the exact same text. Not sure why.

@pthiess
Copy link
Contributor

pthiess commented Jun 28, 2012

Reviewed, seems related to #1111

@ghost ghost assigned redmunds Jul 20, 2012
@redmunds
Copy link
Contributor

redmunds commented Aug 7, 2012

Added Mac-only tag. Interesting that this does not seem to reproduce in brackets-shell. @peterflynn can you reproduce this in brackets-shell? If not, then it may not be worth the effort.

@peterflynn
Copy link
Member Author

Yep, confirmed -- still repros in brackets-app but not in brackets-shell. CEF must have been sending bad events to CodeMirror.

@redmunds
Copy link
Contributor

redmunds commented Aug 8, 2012

Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants