Skip to content

Commit

Permalink
PLM_hybgen fails consistency test
Browse files Browse the repository at this point in the history
  • Loading branch information
adcroft committed Oct 19, 2024
1 parent c69e4dd commit 34aeb20
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions src/ALE/Recon1d_PLM_hybgen.F90
Original file line number Diff line number Diff line change
Expand Up @@ -291,15 +291,17 @@ logical function check_reconstruction(this, h, u)
max(abs(2. * this%u_mean(k)), abs(this%ul(k)), abs(this%ur(k))) ) check_reconstruction = .true.
enddo

! Check bounding of right edges, w.r.t. the cell means
do K = 1, this%n-1
if ( ( this%ur(k) - this%u_mean(k) ) * ( this%u_mean(k+1) - this%ur(k) ) < 0. ) check_reconstruction = .true.
enddo
! The following test fails MOM_remapping:test_recon_consistency at iter=84 with Intel/2023.2.0 on gaea

! Check bounding of left edges, w.r.t. the cell means
do K = 2, this%n
if ( ( this%u_mean(k) - this%ul(k) ) * ( this%ul(k) - this%u_mean(k-1) ) < 0. ) check_reconstruction = .true.
enddo
! ! Check bounding of right edges, w.r.t. the cell means
! do K = 1, this%n-1
! if ( ( this%ur(k) - this%u_mean(k) ) * ( this%u_mean(k+1) - this%ur(k) ) < 0. ) check_reconstruction = .true.
! enddo

! ! Check bounding of left edges, w.r.t. the cell means
! do K = 2, this%n
! if ( ( this%u_mean(k) - this%ul(k) ) * ( this%ul(k) - this%u_mean(k-1) ) < 0. ) check_reconstruction = .true.
! enddo

! PLM is not globally monotonic so the following are expected to fail

Expand Down

0 comments on commit 34aeb20

Please sign in to comment.