Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'lang' param not bypassing languagePicker selection view #3218

Closed
cahirodoherty-learningpool opened this issue Aug 6, 2021 · 0 comments · Fixed by #3219
Closed

'lang' param not bypassing languagePicker selection view #3218

cahirodoherty-learningpool opened this issue Aug 6, 2021 · 0 comments · Fixed by #3219
Assignees
Labels

Comments

@cahirodoherty-learningpool
Copy link
Contributor

Subject of the issue/enhancement/features

Passed 'lang' param is not bypassing the languagePicker language select screen

Your environment

Locally served adapt course

Steps to reproduce

Create a multilanguage course (including 'fr' for example) with languagePicker turned on
Serve the course locally and append index.html?lang='fr'

Expected behaviour

The languagePicker selection screen should be bypassed and the 'fr' version of the course should be presented

Actual behaviour

Language selection screen is presented.
_defaultLanguage is being set in the framework configModel, but the languagePicker attribute _showOnCourseLoad is true, so it is never taken into account

I propose that the '_activeLanguage' should be set on the configModel and the languagePicker should pick up on this. It will not exist as a config value if not passed as a param and therefore can be used to bypass the selection view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant