Adapt.scrollTo: assumes the selector parameter will always refer to an 'Adapt Element'

[moloko]

Prior to v5.7.0 you could do something like Adapt.scrollTo('.c-110 .component__feedback') - but the change from #2761 means this no longer works - as it now assumes you're trying to scroll to an 'Adapt element', so does Adapt.findById on it (to check if it has rendered and wait if not) - which fails as "c-110 .component__feedback" is obviously not a valid Adapt ID.

Possible solution: change parameter to selectorOrAdaptId and only perform the 'check if ready' code if the supplied parameter is an Adapt ID?

Side note: should also update the JSDoc comment for this to make it clear that it's a CSS 'class' selector that's required.

[moloko]

As a temporary workaround in my project, I changed this:

adapt_framework/src/core/js/scrolling.js

Lines 113 to 119 in 2b684d5

	const currentModelId = selector.replace(/\./g, '');
	const currentModel = Adapt.findById(currentModelId);
	if (!currentModel) return;
	if (!currentModel.get('_isRendered') || !currentModel.get('_isReady')) {
	await Adapt.parentView.renderTo(currentModelId);
	}

to this:

const currentModelId = selector.replace(/\./g, '');
const currentModel = Adapt.findById(currentModelId);
if (currentModel && (!currentModel.get('_isRendered') || !currentModel.get('_isReady'))) {
  await Adapt.parentView.renderTo(currentModelId);
}