Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to underscore v1.9.x? #2047

Closed
moloko opened this issue Apr 21, 2018 · 7 comments · Fixed by #2177
Closed

update to underscore v1.9.x? #2047

moloko opened this issue Apr 21, 2018 · 7 comments · Fixed by #2177

Comments

@moloko
Copy link
Contributor

moloko commented Apr 21, 2018

looks like it has a few useful new additions...
http://underscorejs.org/#1.9.0

@lc-thomasberger
Copy link
Member

Should we move to lodash instead? .... it should be much faster than underscore.

@oliverfoster
Copy link
Member

lodash vs all.
lodash does have much extended functionality.
underscore usage is in decline.
lodash definitely probably fully supports backbone.

@moloko
Copy link
Contributor Author

moloko commented Apr 24, 2018

Have done a quick test of Underscore v1.9.0 in FF, IE11 and iOS11 (iPad) and all seems for the OOTB content - but since I can see that a couple of bugs have already been logged against Underscore v1.9.0 we may as well wait for the v1.9.1 release just to be on the safe side

As agreed in the weekly standup let's park switching to lodash for a future major release

@moloko moloko changed the title update to underscore v1.9.0? update to underscore v1.9.x? Apr 24, 2018
@tomgreenfield
Copy link
Contributor

Ready when you are, @moloko.

@oliverfoster
Copy link
Member

oliverfoster commented Jul 2, 2018

lodash vs breaks with underscore btw. i found out to my detriment the other day. no pluck only map. (i know you're not talking lodash @tomgreenfield, just wanted to say they broken the compatibility whilst i remember.)

@brian-learningpool
Copy link
Member

So the idea is to go to v1.9.1?

@moloko
Copy link
Contributor Author

moloko commented Jul 2, 2018

@brian-learningpool that's the plan. We're currently on v1.8.3 (released April 2015!) and v1.9.1 is the latest version.

I'll give it a quick test against OOTB adapt first in a few browsers and report back, we can decide whether to proceed or not from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants