Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class of "submitted" not added to incorrectly answered MCQ and GMCQ #1089

Closed
andrewhosgood opened this issue Jun 6, 2016 · 6 comments
Closed

Comments

@andrewhosgood
Copy link
Contributor

Pretty sure this is related to #921, but when answering an MCQ (or GMCQ), the class of submitted is not added to the .component-widget when you submit an incorrect answer.

Clicking "Show Answer" will add the missing class in.

Used to be: https://github.com/adaptlearning/adapt_framework/blob/v2.0.9/src/core/js/views/questionView.js#L220

Now: https://github.com/adaptlearning/adapt_framework/blame/v2.0.10/src/core/js/views/questionView.js#L148

@andrewhosgood
Copy link
Contributor Author

...of course I'm speculating entirely where the actual issue lies

@moloko
Copy link
Contributor

moloko commented Jun 6, 2016

if we go ahead with something similar to what is proposed in #921, that would certainly help prevent this kind of issue from happening but otherwise I don't see how it would be related?

@andrewhosgood
Copy link
Contributor Author

Sorry, that's what I meant - there's some disparity between the model and the view which will be solved by #921.

When you submit the answer, it used to show marking on the item options, styled by the class of submitted. Someone pointed out to me the other day that it no longer does that.

@tomgreenfield
Copy link
Contributor

Duplicate of #1114?

@andrewhosgood
Copy link
Contributor Author

Yes, or rather #1114 is a duplicate of this 😏

@tomgreenfield
Copy link
Contributor

Done in bb2396f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants