Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toBoolean not fired for cli arguments #2024

Closed
lc-thomasberger opened this issue Jul 19, 2018 · 2 comments
Closed

toBoolean not fired for cli arguments #2024

lc-thomasberger opened this issue Jul 19, 2018 · 2 comments
Assignees
Labels
S: merged Completed, reviewed, and merged issues T: bug
Milestone

Comments

@lc-thomasberger
Copy link
Member

BUG

When config options are passed in as cli arguments during installation, the toBoolean hook is not executed. This can break installation in lib/mailer as you can not disable certain config options.

Expected Behaviour

Boolean config options should always be properly converted into boolean regarding of there input type.

Versions

  • Authoring Tool Version: 0.5.0
  • Framework Version: --
  • Operating System: --
  • Browser: --
@lc-thomasberger
Copy link
Member Author

I think the config module should handle the conversion of y/n into true/false.

@taylortom
Copy link
Member

taylortom commented Jul 20, 2018

This is due a limitation of prompt -- we had the same problem with the config.json overrides (See install.js#L273 for a similar issue with y/n/true/false)

@lc-thomasberger lc-thomasberger added this to the 0.5.1 milestone Aug 8, 2018
@lc-thomasberger lc-thomasberger self-assigned this Aug 8, 2018
@taylortom taylortom added the S: merged Completed, reviewed, and merged issues label Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: merged Completed, reviewed, and merged issues T: bug
Projects
None yet
Development

No branches or pull requests

3 participants