Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview route is sending invalid status codes #1882

Closed
dancgray opened this issue Feb 21, 2018 · 0 comments
Closed

Preview route is sending invalid status codes #1882

dancgray opened this issue Feb 21, 2018 · 0 comments
Labels
S: merged Completed, reviewed, and merged issues T: bug
Milestone
0.6.1

Comments

@dancgray
Copy link
Member

Expected Behaviour

Any preview responses should have a valid HTTP status

Actual Behaviour

Server responds with HTTP status of "undefined" when request is aborted.
Probably due
status-issue.txt
to routes/preview/index.js lines 83, 116 and 128

Value for err is "Error: Request aborted"

Should we be passing 400 status in this circumstance?

Steps to Reproduce

I only seem to be able to reproduce this on larger courses and when using Firefox.

It has also been reported on the forum here.

Versions

  • Authoring Tool Version: 0.4.1
  • Framework Version: v2.2.5
  • Operating System: MacOS
  • Browser: Firefox 58
@dancgray dancgray mentioned this issue Sep 5, 2018
Merged
@taylortom taylortom added this to the 0.5.1 milestone Sep 5, 2018
@taylortom taylortom added the S: merged Completed, reviewed, and merged issues label Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S: merged Completed, reviewed, and merged issues T: bug
Projects
None yet
Milestone
0.6.1
Development

No branches or pull requests
3 participants
@taylortom @dancgray @canstudios-nicolaw