From e945eea52ae343e3a32785d18850438e56b066d3 Mon Sep 17 00:00:00 2001 From: Nayan Khedkar Date: Mon, 1 Jun 2020 15:09:07 +0530 Subject: [PATCH 1/4] added language specific class to popup --- js/languagePickerDrawerView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/languagePickerDrawerView.js b/js/languagePickerDrawerView.js index 02ff8a4..7d7f898 100644 --- a/js/languagePickerDrawerView.js +++ b/js/languagePickerDrawerView.js @@ -29,7 +29,7 @@ define([ var data = this.model.getLanguageDetails(newLanguage); var promptObject = { - _classes: 'is-ltr', + _classes: 'is-ltr is-lang-' + newLanguage, title: data.warningTitle, body: data.warningMessage, _prompts:[ From 065ac6e34216ab28a7b22e3017f3bbd19c22a501 Mon Sep 17 00:00:00 2001 From: Nayan Khedkar Date: Tue, 2 Jun 2020 17:51:41 +0530 Subject: [PATCH 2/4] added _attributes to set on popup --- js/languagePickerDrawerView.js | 1 + 1 file changed, 1 insertion(+) diff --git a/js/languagePickerDrawerView.js b/js/languagePickerDrawerView.js index 7d7f898..3bec23c 100644 --- a/js/languagePickerDrawerView.js +++ b/js/languagePickerDrawerView.js @@ -29,6 +29,7 @@ define([ var data = this.model.getLanguageDetails(newLanguage); var promptObject = { + _attributes: { lang: newLanguage }, _classes: 'is-ltr is-lang-' + newLanguage, title: data.warningTitle, body: data.warningMessage, From 76b0a43fe4316a4bd951ecf7450e94c841b55cbe Mon Sep 17 00:00:00 2001 From: Nayan Khedkar Date: Fri, 26 Jun 2020 08:41:45 +0530 Subject: [PATCH 3/4] bumped framework dependency --- bower.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bower.json b/bower.json index 8e29638..03c1abb 100644 --- a/bower.json +++ b/bower.json @@ -5,7 +5,7 @@ "url": "git://github.com/adaptlearning/adapt-contrib-languagePicker.git" }, "version": "4.0.0", - "framework": ">=5", + "framework": ">=5.6", "homepage": "https://github.com/adaptlearning/adapt-contrib-languagePicker", "issues": "https://github.com/adaptlearning/adapt_framework/issues/new", "extension": "languagePicker", From 4fe3921baa0b57ddc607d5e2a536277495e17362 Mon Sep 17 00:00:00 2001 From: Nayan Khedkar Date: Tue, 30 Jun 2020 08:51:04 +0530 Subject: [PATCH 4/4] minor tweak to add direction class --- js/languagePickerDrawerView.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/js/languagePickerDrawerView.js b/js/languagePickerDrawerView.js index 3bec23c..6b9429a 100644 --- a/js/languagePickerDrawerView.js +++ b/js/languagePickerDrawerView.js @@ -30,7 +30,7 @@ define([ var promptObject = { _attributes: { lang: newLanguage }, - _classes: 'is-ltr is-lang-' + newLanguage, + _classes: `is-lang-${newLanguage} ${data._direction === 'rtl' ? 'is-rtl' : 'is-ltr'}`, title: data.warningTitle, body: data.warningMessage, _prompts:[ @@ -46,10 +46,6 @@ define([ _showIcon: true }; - if (data._direction === 'rtl') { - promptObject._classes = 'is-rtl'; - } - //keep active element incase the user cancels - usually navigation bar icon //move drawer close focus to #focuser if ($.a11y) {