Missing local install plugin

[chris-steele]

What happened?

If the contentplugin collection (in the database) has plugins marked as locally installed but the plugin is missing in the file system (i.e. not present in APP_DATA/data/contentplugins) the tool will error silently and the installation of other plugins may fail. The tool runs but editing content typically produces errors (citing missing schemas).

The error is thrown when attempting to read the plugin info here.

How should we deal with this scenario?

Expected behaviour

No response

Steps to reproduce

Have a plugin marked as locally installed in the database, but not present in the file system.

Authoring tool version

master

Framework version

No response

What browsers are you seeing the problem on?

No response

Relevant log output

No response

[taylortom]

I'm not able to replicate this one with the latest deps, possibly resolved?

[chris-steele]

Unfortunately I can't recall the steps that led to this scenario, but it may have arisen with imports. I don't believe it is related to the paths issue solved here, however.

Will keep a watch for this issue.

[taylortom]

Please reopen if you manage to replicate

[chris-steele]

@taylortom just replicated this. I was using a database that had the usual core plugins. The DB also listed adapt-pageNav (marked as locally installed). However, this plugin was not on the file system. As per the original description the tool does not flag that the plugin is missing and errors silently; failing to continue with schema discovery+loading etc. The tool initialises and loads but as soon as you try to access/create content you get a schema error. Typically the error is that the text-component schema is missing, but inspecting the runtime schema collection reveals that many more are missing.

[chris-steele]

@taylortom to account for the above and prevent misleading schema errors I think we need to throw an error if plugins marked local are missing. Shall I do this?

[taylortom]

We should be logging errors already - is this not happening?

https://github.com/adapt-security/adapt-authoring-contentplugin/blob/master/lib/ContentPluginModule.js#L95

[chris-steele]

There is an error (thrown by adapt-cli), but the problem plugin isn't identified and the tool continues to load and run. Perhaps this should be a fatal error as it renders content creation impossible?