Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend exc_info=True over formatting exception in message #44

Open
adamchainz opened this issue Sep 6, 2023 · 0 comments
Open

Recommend exc_info=True over formatting exception in message #44

adamchainz opened this issue Sep 6, 2023 · 0 comments

Comments

@adamchainz
Copy link
Owner

Description

Hastily-written log messages often use the exception in the message:

try:
    float()
except Exception as exc:
    logging.info("Floating failed: %s", exc)

This is not a great pattern as str(exc) reveals little info - no stack trace! Better to use exc_info=True.

Let’s detect exc or str(exc) used in arguments and recommend exc_info=True instead. type(exc) is okay as a parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant