Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect logger.log with non-integer first argument #11

Open
adamchainz opened this issue Aug 24, 2023 · 3 comments
Open

Detect logger.log with non-integer first argument #11

adamchainz opened this issue Aug 24, 2023 · 3 comments

Comments

@adamchainz
Copy link
Owner

Description

Example:

logger.log("INFO", "Message")

This looks like it could work, but log() only takes an integer such as logging.INFO.
@adamchainz
Copy link
Owner Author

adamchainz commented Sep 4, 2023 •
edited
Loading

This is a bit duplicative of type-checking, but I think at least checking for strings is worth it. Type-checking still has fairly low adoption.

@adamchainz
Copy link
Owner Author

Meh, log() is not often used.

@adamchainz
Copy link
Owner Author

Actually should be easy if implementing #30.

@adamchainz adamchainz reopened this Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adamchainz