Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded kwarg handler in setters #9863

Closed
jepler opened this issue Dec 4, 2024 · 1 comment
Closed

Remove unneeded kwarg handler in setters #9863

jepler opened this issue Dec 4, 2024 · 1 comment
Assignees

Comments

@jepler
Copy link
Member

jepler commented Dec 4, 2024

Based on text search, the following getters in audiofilters & audiodelays modules can have their kwarg handling removed. Each instance may save ~80 bytes of code/flash space:

shared-bindings/audiodelays/Echo.c:static mp_obj_t audiodelays_echo_obj_set_delay_ms
shared-bindings/audiodelays/Echo.c:static mp_obj_t audiodelays_echo_obj_set_decay
shared-bindings/audiodelays/Echo.c:static mp_obj_t audiodelays_echo_obj_set_mix
shared-bindings/audiodelays/Echo.c:static mp_obj_t audiodelays_echo_obj_set_freq_shift
shared-bindings/audiofilters/Filter.c:static mp_obj_t audiofilters_filter_obj_set_filter
shared-bindings/audiofilters/Filter.c:static mp_obj_t audiofilters_filter_obj_set_mix

ping @relic-se for interest (I don't seem to be able to assign you directly on the issue)

Please feel free to handle this as 1 or 2 PRs as you prefer.

@dhalbert
Copy link
Collaborator

dhalbert commented Dec 9, 2024

Fixed by #9864.

@dhalbert dhalbert closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants