Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Espressif BLE: Heart Rate not working #9338

Closed
dhalbert opened this issue Jun 15, 2024 · 0 comments · Fixed by #9374
Closed

Espressif BLE: Heart Rate not working #9338

dhalbert opened this issue Jun 15, 2024 · 0 comments · Fixed by #9374
Assignees
Labels
ble espressif applies to multiple Espressif chips
Milestone

Comments

@dhalbert
Copy link
Collaborator

Testing on main (after #9325):

Run ble_heart_rate_simpletest on a Metro ESP32-S3. Does not work on 9.0.5 either.

Fixes and diagnoses already done:

  1. xTaskNotifyWait(0, 0, (uint32_t *)&error_code, 200); used several times. 200 is ticks. We changed ticks from 1 per 10msecs to 1 per msec in CONFIG_FREERTOS_HZ = 1000 #9134. I changed to use pdMS_TO_TICKS() to make it tick-length independent.
  2. xTaskNotifyWait() above may return error_code BLE_HS_EAGAIN, which has to be handled. I added a routine to handle that and called it in various places.
  3. In progress: The default characteristic size for a remote characteristic appears to be zero. By comparison, on nordic it's 20. The zero causes a PacketBuffer only big enough for a 2-byte length to be constructed. That then invokes code which never grows the packet buffer. Looking into this to see where the default characteristic size is set up.
@dhalbert dhalbert self-assigned this Jun 15, 2024
@dhalbert dhalbert added espressif applies to multiple Espressif chips ble labels Jun 15, 2024
@dhalbert dhalbert added this to the 9.1.0 milestone Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ble espressif applies to multiple Espressif chips
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant