RX and TX in use on QTPY ESP32S2

[Neradoc]

Trying to use board.TX or board.RX, or board.UART raises a pin in use error. For example like this:

import board
uart = board.UART()

ValueError: TX in use

I assume that comes from #5894

circuitpython/ports/espressif/boards/adafruit_qtpy_esp32s2/mpconfigboard.h

Lines 53 to 54 in eeeef38

	#define DEBUG_UART_RX DEFAULT_UART_BUS_RX
	#define DEBUG_UART_TX DEFAULT_UART_BUS_TX

[tannewt]

This should only be the case on DEBUG=1 builds. Did you try a DEBUG=0 build?

[Neradoc]

That is with latest from S3. It doesn't look like there is any condition other than the pins definitions existing in supervisor/shared/serial.c. There's a few places in the file that test it. Am I missing something ?

circuitpython/supervisor/shared/serial.c

Lines 62 to 74 in 5010170

	void serial_early_init(void) {
	#if defined(DEBUG_UART_TX) && defined(DEBUG_UART_RX)
	debug_uart.base.type = &busio_uart_type;
	const mcu_pin_obj_t *rx = MP_OBJ_TO_PTR(DEBUG_UART_RX);
	const mcu_pin_obj_t *tx = MP_OBJ_TO_PTR(DEBUG_UART_TX);
	common_hal_busio_uart_construct(&debug_uart, tx, rx, NULL, NULL, NULL,
	false, 115200, 8, BUSIO_UART_PARITY_NONE, 1, 1.0f, 64,
	buf_array, true);
	common_hal_busio_uart_never_reset(&debug_uart);
	#endif
	}

Should the pins definition for the QT PY be conditioned by the DEBUG level, or should it be changed in serial.c with something like that ?

#define CIRCUITPY_DEBUG_UART CIRCUITPY_DEBUG && defined(DEBUG_UART_TX) && defined(DEBUG_UART_RX)

[tannewt]

Ah, you are right. Yes, I expect it to be conditioned on whether it is a debug build. I'm not sure where the best place is to do that.