-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matrix vector multiplication broken in ulab #4250
Comments
@v923z I reproduced the same in the legacy branch of ulab as well as in master branch. Can you please look into it? If possible we'd like it fixed in legacy so we can take the fix in 6.2. |
@jepler Sure! What is the deadline? I should be able to fix it tomorrow. |
@jepler @kevin-tracy v923z/micropython-ulab#339 should hopefully fix the issue. |
@v923z thank you very much! Out of curiosity, how come that change was made to the micropython-ulab repo instead of circuitpython-ulab? |
@kevin-tracy Because @jepler simply links to micropython-ulab, so it makes sense to implement all fixes there. I think, having the same thing at two different places is generally not a sound idea. |
Initially we thought we might have to make local changes to allow ulab to work with circuitpython but v923z has been very responsive to all our needs, keeping the changes in his repo. It is working out very well! |
@kevin-tracy I forgot to ask, do you think you could write a test script for |
@v923z I would be happy to! I'll add them sometime this week. |
@kevin-tracy Many thanks! @jepler Jeff, I hope that my appeal for testing doesn't qualify as hijacking the thread. |
@v923z this might not be the right place to ask this question, but in writing tests I'm having an issue generating the .exp file for a new test. In the readme of the repo it says:
But when I do this for a new
Am I misunderstanding something or should I make an issue for this? Thanks. |
Two quick updates to the above comment:
On my board I am running |
@kevin-tracy Sorry, I didn't spell this out, but anything written on But more importantly, the fix is in a still-open PR, v923z/micropython-ulab#339, so Jeff hasn't yet pulled in the changes, because the PR is still not resolved. Hence, loading an adafruit-compiled piece of firmware is not going to make the cut here. What you can do, however, is simply clone https://github.com/v923z/micropython-ulab/, switch to the |
Is the matrix multiplication issue fixed for circuitpython? |
@amitkrbhuyan we believe it is fixed in the current stable release, 6.2.0. |
Matrix vector multiplication isn't working in ulab on the following version:
Adafruit CircuitPython 6.1.0 on 2021-01-21; Adafruit Grand Central M4 Express with samd51p20
Here is an example of it's current functionality:
Ideally, this would work similarly to NumPy where a 2D array multiplied by a 1D array results in a 1D array. Does this functionality exist under a different function? Thank you.
The text was updated successfully, but these errors were encountered: