forked from micropython/micropython
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment Fix - QSPI SCK and CS Reversed #4016
Comments
good eyes! could you submit a PR with the fix? :) |
Sure thing! It'll be my first! |
awwwseome! |
Thanks! |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I just noticed a comment that could be improved for clarity, as I referenced it and it led me to think I had my QSPI SCK and CS pins reversed.
circuitpython/ports/atmel-samd/boards/itsybitsy_m4_express/mpconfigboard.h
15 // DotStar pins, QSPI CS, and QSPI SCK
16 #define MICROPY_PORT_B (PORT_PB02 | PORT_PB03 | PORT_PB10 | PORT_PB11)
As it stands, PORT_PB02 and PORT_PB03 are understood to be the DotStar Pins, PORT_PB10 the QSPI CS, and PORT_PB11 the QSPI SCK. While it is correct about the DotStar pins, the QSPI CS and QSPI SCK are reversed.
I recommend replacing the comment on Line 15 with:
// DotStar SCK, DotStar MOSI, QSPI SCK, and QSPI CS
The text was updated successfully, but these errors were encountered: