Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Fix - QSPI SCK and CS Reversed #4016

Closed
mrangen opened this issue Jan 17, 2021 · 5 comments · Fixed by #4019
Closed

Comment Fix - QSPI SCK and CS Reversed #4016

mrangen opened this issue Jan 17, 2021 · 5 comments · Fixed by #4019

Comments

@mrangen
Copy link

mrangen commented Jan 17, 2021

I just noticed a comment that could be improved for clarity, as I referenced it and it led me to think I had my QSPI SCK and CS pins reversed.

circuitpython/ports/atmel-samd/boards/itsybitsy_m4_express/mpconfigboard.h

15 // DotStar pins, QSPI CS, and QSPI SCK
16 #define MICROPY_PORT_B (PORT_PB02 | PORT_PB03 | PORT_PB10 | PORT_PB11)

As it stands, PORT_PB02 and PORT_PB03 are understood to be the DotStar Pins, PORT_PB10 the QSPI CS, and PORT_PB11 the QSPI SCK. While it is correct about the DotStar pins, the QSPI CS and QSPI SCK are reversed.

I recommend replacing the comment on Line 15 with:

// DotStar SCK, DotStar MOSI, QSPI SCK, and QSPI CS

@ladyada
Copy link
Member

ladyada commented Jan 17, 2021

good eyes! could you submit a PR with the fix? :)

@mrangen
Copy link
Author

mrangen commented Jan 18, 2021

Sure thing! It'll be my first!

@ladyada
Copy link
Member

ladyada commented Jan 18, 2021

awwwseome!
here's a guide that may help
https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github

@mrangen
Copy link
Author

mrangen commented Jan 18, 2021

Thanks!

@tannewt tannewt linked a pull request Jan 20, 2021 that will close this issue
@tannewt
Copy link
Member

tannewt commented Jan 20, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants