Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB: Check number of descriptors at build time #3066

Closed
jepler opened this issue Jun 24, 2020 · 2 comments
Closed

USB: Check number of descriptors at build time #3066

jepler opened this issue Jun 24, 2020 · 2 comments
Labels
Milestone

Comments

@jepler
Copy link
Member

jepler commented Jun 24, 2020

In #3038 @dhalbert noted it would be handy to check that the enabled USB devices fit within the MCU-specific number of USB descriptors:

Another check we could add (this is getting complicated) is counting endpoints for boards with limited endpoints, and warning you there are too many. It has to know CDC takes 2, and others take only one. It could count words/commas in USB_DEVICES.

As it stands, I think such builds succeed but crash when loaded on a board.

@jepler jepler added this to the Long term milestone Jun 24, 2020
@jepler jepler added the usb label Jun 24, 2020
@jepler
Copy link
Member Author

jepler commented Mar 15, 2021

@dhalbert didn't you add this checking to all platforms when you added the 2nd CDC? If so, please close.

@dhalbert
Copy link
Collaborator

I didn't even know there was an issue :). FIxed by #4215.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants