Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests with CPython Native Socket #28

Closed
brentru opened this issue May 13, 2020 · 2 comments · Fixed by #31
Closed

Requests with CPython Native Socket #28

brentru opened this issue May 13, 2020 · 2 comments · Fixed by #31
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brentru
Copy link
Member

brentru commented May 13, 2020

The CircuitPython_Requests module is currently untested with CPython's socket low-level interface.

A new requests_simpletest example would need to be added, too.

After updating for the CPython native socket, we may need to update ESP32, Ethernet and Cellular socket-like implementations for compatibility.

@brentru brentru added enhancement New feature or request good first issue Good for newcomers labels May 13, 2020
@tannewt
Copy link
Member

tannewt commented May 14, 2020

Furthermore, it should always use the recv*_into forms for receive to minimize memory allocations. (The others create new byte arrays to return.)

@tannewt tannewt self-assigned this Jul 1, 2020
@tannewt
Copy link
Member

tannewt commented Jul 1, 2020

I'm working on this.

@tannewt tannewt linked a pull request Sep 3, 2020 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants