Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"fade" method throws Exception when both params are None #52

Closed
EAGrahamJr opened this issue Feb 16, 2023 · 1 comment · Fixed by #53
Closed

"fade" method throws Exception when both params are None #52

EAGrahamJr opened this issue Feb 16, 2023 · 1 comment · Fixed by #53

Comments

@EAGrahamJr
Copy link
Contributor

Adafruit_CircuitPython_IS31FL3731/adafruit_is31fl3731/__init__.py

Line 193 in 97eb72a

def fade(self, fade_in=None, fade_out=None, pause=0):

It seems there's a missing return that should occur when both parameters are None. If that does not occur, line 209 will (obviously) fail.
@tannewt
Copy link
Member

tannewt commented Feb 16, 2023

Would you mind making a PR? I think you are right what the fix is. https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github

@EAGrahamJr EAGrahamJr mentioned this issue Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return from fade on "None"
2 participants
@tannewt @EAGrahamJr