Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adafruit_bno055.py is failing pylint #59

Closed
evaherrada opened this issue Oct 29, 2020 · 2 comments · Fixed by #60
Closed

adafruit_bno055.py is failing pylint #59

evaherrada opened this issue Oct 29, 2020 · 2 comments · Fixed by #60

Comments

@evaherrada
Copy link
Collaborator

See Actions run

************* Module adafruit_bno055
adafruit_bno055.py:137:8: R1725: Consider using Python 3 style super() without arguments (super-with-arguments)
adafruit_bno055.py:141:17: R1725: Consider using Python 3 style super() without arguments (super-with-arguments)

Here are the 2 methods that are failing:
Method 1

136    def __init__(self, register_address, struct_format, scale):
137        super(_ScaledReadOnlyStruct, self).__init__(register_address, struct_format)
138        self.scale = scale

Method 2

140    def __get__(self, obj, objtype=None):
141        result = super(_ScaledReadOnlyStruct, self).__get__(obj, objtype)
142        return tuple(self.scale * v for v in result)

Should I remove the arguments and then try getting it to work that way or should I just add a pylint disable?

@caternuson
Copy link
Contributor

@evaherrada
Copy link
Collaborator Author

@caternuson Cool. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants