Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: do not trim spaces on value returned by getInput #339

Closed
myitcv opened this issue Feb 10, 2020 · 2 comments · Fixed by #802
Closed

core: do not trim spaces on value returned by getInput #339

myitcv opened this issue Feb 10, 2020 · 2 comments · Fixed by #802
Assignees
Labels
bug Something isn't working core

Comments

@myitcv
Copy link

myitcv commented Feb 10, 2020

Describe the bug

As I raised over in the community forums, the core package trims the value returned by getInput:

return val.trim()

I might well be missing something here, but I consider this a bug because it precludes leading/trailing spaces from ever being significant in input values. If the the caller of getInput wants to trim space on the value returned, they can make that decision. As things stand, leading/trailing spaces can never be significant in input values.

This puts input values at odds with environment variables on Linux and macOS (at least).

Please can someone provide the motivation behind this decision?

Thanks

To Reproduce

n/a

Expected behavior

Per above description.

Screenshots

n/a

Desktop (please complete the following information):

n/a

Smartphone (please complete the following information):

n/a

Additional context

None

@myitcv myitcv added the bug Something isn't working label Feb 10, 2020
@bryanmacfarlane
Copy link
Member

I agree.

@bryanmacfarlane bryanmacfarlane self-assigned this Feb 12, 2020
@iamalisajid
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@bryanmacfarlane @myitcv @iamalisajid @thboop and others